Skip to content

Conversation

@pjohnst5
Copy link
Contributor

The windows overlay tests kept hitting:

--- FAIL: TestScaleDeployment (0.30s)
    load_test.go:141: Scale deployment
panic: could not update deployment win-load-test: Operation cannot be fulfilled on deployments.apps "win-load-test": the object has been modified; please apply your changes to the latest version and try again [recovered]
	panic: could not update deployment win-load-test: Operation cannot be fulfilled on deployments.apps "win-load-test": the object has been modified; please apply your changes to the latest version and try again

This was most likely because the deployment was not being completely deleted, before each test run
Now we wait for the deployment to be deleted before proceeding

@pjohnst5 pjohnst5 requested a review from a team as a code owner October 19, 2023 17:55
@pjohnst5 pjohnst5 requested a review from k-routhu October 19, 2023 17:55
@pjohnst5
Copy link
Contributor Author

Closing in favor of #2312 which is the same, but on a branch directly from ACN, since we are no longer allowed to use forks

@pjohnst5 pjohnst5 closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants