Skip to content

chore: wait for deployment to completely delete before proceeding #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2023
Merged

chore: wait for deployment to completely delete before proceeding #2312

merged 3 commits into from
Oct 19, 2023

Conversation

@pjohnst5
Copy link
Contributor

@pjohnst5 pjohnst5 commented Oct 19, 2023

The windows overlay tests kept hitting:

--- FAIL: TestScaleDeployment (0.30s)
    load_test.go:141: Scale deployment
panic: could not update deployment win-load-test: Operation cannot be fulfilled on deployments.apps "win-load-test": the object has been modified; please apply your changes to the latest version and try again [recovered]
	panic: could not update deployment win-load-test: Operation cannot be fulfilled on deployments.apps "win-load-test": the object has been modified; please apply your changes to the latest version and try again

This was most likely because the deployment was not being completely deleted, before each test run
Now we wait for the deployment to be deleted before proceeding

@pjohnst5 pjohnst5 requested a review from a team as a code owner October 19, 2023 18:33
@pjohnst5 pjohnst5 requested a review from smittal22 October 19, 2023 18:33
@pjohnst5 pjohnst5 changed the title Paujohns/fix overlay win tests chore: wait for deployment to completely delete before proceeding Oct 19, 2023
@pjohnst5 pjohnst5 mentioned this pull request Oct 19, 2023
Closed
jpayne3506
jpayne3506 requested changes Oct 19, 2023
View reviewed changes
@pjohnst5 @jpayne3506
chore: fix delay
1a19571 
Co-authored-by: John Payne <89417863+jpayne3506@users.noreply.github.com>
Signed-off-by: Paul Johnston <35265851+pjohnst5@users.noreply.github.com>
@pjohnst5 pjohnst5 enabled auto-merge (squash) October 19, 2023 18:40
@pjohnst5 pjohnst5 merged commit 10e86a2 into master Oct 19, 2023
@pjohnst5 pjohnst5 deleted the paujohns/fix-overlay-win-tests branch October 19, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpayne3506 jpayne3506 jpayne3506 approved these changes

@paulyufan2 paulyufan2 paulyufan2 approved these changes

@smittal22 smittal22 Awaiting requested review from smittal22 smittal22 is a code owner automatically assigned from Azure/azure-sdn-members

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pjohnst5 @jpayne3506 @paulyufan2