Skip to content

Locking loop-back adapter operations. #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Locking loop-back adapter operations. #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions cns/networkcontainers/networkcontainers_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,15 @@ import (
"os/exec"
"strconv"
"strings"
"sync"

"github.com/Azure/azure-container-networking/cns"
"github.com/Azure/azure-container-networking/log"
"github.com/containernetworking/cni/libcni"
)

var loopbackOperationLock = &sync.Mutex{}

func createOrUpdateInterface(createNetworkContainerRequest cns.CreateNetworkContainerRequest) error {
// Create Operation is only supported for WebApps only on Windows
if createNetworkContainerRequest.NetworkContainerType != cns.WebApps {
Expand Down Expand Up @@ -87,7 +90,10 @@ func setWeakHostOnInterface(ipAddress string) error {

log.Printf("[Azure CNS] Going to enable weak host send/receive on interface: %v", args)
c := exec.Command("cmd", args...)

loopbackOperationLock.Lock()
bytes, err := c.Output()
loopbackOperationLock.Unlock()

if err == nil {
log.Printf("[Azure CNS] Successfully updated weak host send/receive on interface %v.\n", string(bytes))
Expand Down Expand Up @@ -136,7 +142,10 @@ func createOrUpdateWithOperation(createNetworkContainerRequest cns.CreateNetwork

log.Printf("[Azure CNS] Going to create/update network loopback adapter: %v", args)
c := exec.Command("cmd", args...)

loopbackOperationLock.Lock()
bytes, err := c.Output()
loopbackOperationLock.Unlock()

if err == nil {
log.Printf("[Azure CNS] Successfully created network loopback adapter %v.\n", string(bytes))
Expand Down Expand Up @@ -167,7 +176,10 @@ func deleteInterface(networkContainerID string) error {

log.Printf("[Azure CNS] Going to delete network loopback adapter: %v", args)
c := exec.Command("cmd", args...)

loopbackOperationLock.Lock()
bytes, err := c.Output()
loopbackOperationLock.Unlock()

if err == nil {
log.Printf("[Azure CNS] Successfully deleted network container %v.\n", string(bytes))
Expand Down