verifytypes#46524
Merged
Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Member
Author
|
/azp run python - appnetwork |
Member
Author
|
/azp run python - horizondb |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - appnetwork |
Member
Author
|
/azp run python - horizondb |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the type verification tooling configuration by bumping Pyright and improving error handling when --outputjson isn’t valid.
Changes:
- Bump the pinned Pyright version used by
verifytypes. - Add fallback diagnostics when Pyright doesn’t emit valid JSON (both on success and failure).
- Update
pyrightconfig.jsonto target Python 3.10.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pyrightconfig.json | Updates Pyright’s configured target Python version to 3.10. |
| eng/tools/azure-sdk-tools/azpysdk/verifytypes.py | Bumps Pyright version and adds robust handling + diagnostic reruns when JSON output is invalid. |
fafhrd91
pushed a commit
to fafhrd91/azure-sdk-for-python
that referenced
this pull request
Apr 28, 2026
* testing fix Co-authored-by: Copilot <copilot@github.com> * verbose output * we dont support 3.9 anymore * update verifytypes pyright * add guard * Revert unrelated pyproject.toml license changes Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note the bump in version may decrease scores for verifytypes in packages that have pyright disabled closes #46426