[typespec-python-regenerate workflow] Harden TypeSpec Python README warning workflow#47828
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the TypeSpec Python Regenerate Tests workflow by eliminating its dependency on a checked-in README template file. Previously the workflow copied eng/tools/azure-sdk-tools/emitter/generated/template/README.md onto every generated test-package README (and had to guard the template path during the find). Now the short "test code — do not install from PyPI" warning is generated inline into a temp file, removing the external file dependency and simplifying the copy logic.
Changes:
- Replaced the template-file copy with an inline heredoc that writes the warning to a
mktemptemp file (cleaned up via anEXITtrap). - Dropped the now-unnecessary
! -path "$TARGET/template/*"exclusion from thefind, keeping only the top-levelgenerated/README.mdexclusion. - Removed stale template-specific guidance from the missing-branch error message.
ChenxiJiang333
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Validation:
git diff --check -- .github/workflows/typespec-python-regenerate.ymlTest: https://github.com/Azure/azure-sdk-for-python/actions/runs/28645359471