Howie/release - #48866
Conversation
…est, add new hosted agent samples for Teams message trigger and reminder preview (#48234) * Remove sample_agent_toolbox_skill.py per bakcned folks and Linda request, add new hosted agent samples for Teams message trigger and reminder preview * change log
… usage; update assets.json tag
* Add A2A protocol support and update related models - Introduced A2ATool and A2AToolboxTool classes for A2A protocol implementation. - Added A2AProtocolVersion enum to define supported A2A protocol versions. - Updated DataGenerationJobOptions to include SimulationSeedDataGenerationJobOptions and removed TaskGenerationDataGenerationJobOptions. - Modified existing models and enums to accommodate new A2A features. - Updated sample agent to utilize the new A2ATool class. - Adjusted beta routines API to remove unsupported parameters and enhance pagination handling. - Updated YAML configuration to reflect repository changes. * Update tsp-location.yaml with latest commit and repository details * Update sample_agent_to_agent.py skip reason in test_samples.py
#48795) * Add BetaAgentInsightMonitorsOperations and related functionality - Introduced `BetaAgentInsightMonitorsOperations` for managing agent insight monitors. - Updated `BetaOperations` to include the new agent insight monitors operations. - Removed outdated sample scripts for multi-agent workflows and MCP approval. - Updated evaluation samples to reflect changes in Azure SDK and improve functionality. - Adjusted role assignment parameters in evaluation samples for better clarity and structure. - Updated `tsp-location.yaml` to include new directories for agent insights and voice agents. * refactor: remove unnecessary RoleAssignmentProperties import in evaluation samples * refactor: remove VoiceAgents from agent feature headers in tests and implementation * refactor: remove VoiceAgents from non-beta optional test cases * feat: add new features for agent insight monitors and Microsoft 365 publishing * refactor: update RoleAssignment import and parameters format in evaluation samples * refactor: update RoleAssignment parameters to use dictionary format in RBAC assignment * feat: add multi-agent workflow samples with synchronous and asynchronous clients * feat: update CHANGELOG and public methods documentation for AgentInsight monitors and Microsoft 365 publishing
|
Azure Pipelines: Successfully started running 1 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
🟡 Changes recommended
Moderate API naming, preview-header, parameter exposure, and model-nullability issues remain unresolved.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Regenerates azure-ai-projects 2.6.0 with new Foundry preview APIs and supporting customizations.
Changes:
- Adds Agent Insights, Microsoft 365 publishing, hosted sessions, routine authorization, shell, and WebIQ APIs.
- Adds custom synchronous and asynchronous Agent Insights pollers.
- Updates feature headers, documentation, samples, and API snapshots.
File summaries
| File | Description |
|---|---|
sdk/ai/azure-ai-projects/tsp-location.yaml |
Updates TypeSpec sources and commit. |
sdk/ai/azure-ai-projects/tests/foundry_features_header/foundry_features_header_test_base.py |
Adds the Agent Insights header expectation. |
sdk/ai/azure-ai-projects/samples/evaluations/sample_evaluations_builtin_with_traces.py |
Updates logs-query result handling. |
sdk/ai/azure-ai-projects/docs/public-methods.md |
Documents Agent Insights operations. |
sdk/ai/azure-ai-projects/CHANGELOG.md |
Lists 2.6.0 features. |
sdk/ai/azure-ai-projects/azure/ai/projects/operations/_patch.py |
Exposes the synchronous Agent Insights client. |
sdk/ai/azure-ai-projects/azure/ai/projects/operations/_patch_agent_insights.py |
Implements the synchronous custom poller. |
sdk/ai/azure-ai-projects/azure/ai/projects/models/_patch.py |
Adds pollers and preview-feature mappings. |
sdk/ai/azure-ai-projects/azure/ai/projects/models/_models.py |
Adds generated models and fields. |
sdk/ai/azure-ai-projects/azure/ai/projects/models/_enums.py |
Adds generated enums. |
sdk/ai/azure-ai-projects/azure/ai/projects/models/__init__.py |
Exports new models and enums. |
sdk/ai/azure-ai-projects/azure/ai/projects/aio/operations/_patch.py |
Exposes the asynchronous Agent Insights client. |
sdk/ai/azure-ai-projects/azure/ai/projects/aio/operations/_patch_agent_insights_async.py |
Implements the asynchronous custom poller. |
sdk/ai/azure-ai-projects/apiview-properties.json |
Updates cross-language API mappings. |
sdk/ai/azure-ai-projects/api.metadata.yml |
Refreshes API snapshot metadata. |
sdk/ai/azure-ai-projects/api.md |
Records the expanded public API. |
Review details
Suppressed comments (6)
sdk/ai/azure-ai-projects/CHANGELOG.md:7
- The Agent Insights release note mentions only models and enums, but the primary customer-facing addition is the new
.beta.agent_insight_monitorssubclient with 13 operations and a custom run poller. Describe that entry point so users can discover and use the feature from the release notes.
* Added supporting AgentInsight* models and enums covering monitors, runs, generated insights, proposed fixes, highlighted and linked traces, costs, token usage, severity, status, and run triggers.
sdk/ai/azure-ai-projects/azure/ai/projects/aio/operations/_patch_agent_insights_async.py:122
- The async status polls lose the required preview opt-in header: the proxy-injected
headersare consumed beforeAsyncLROBasePollingis constructed, and this polling method has no headers in its operation config. Pass the effective headers here so everyOperation-Locationrequest carriesAgentInsights=V1Preview, matchingaio/operations/_patch_memories_async.py:356-361.
AsyncLROBasePolling(lro_delay, path_format_arguments=path_format_arguments, **kwargs),
sdk/ai/azure-ai-projects/azure/ai/projects/models/_models.py:1713
- This list-item property is documented as null whenever the monitor is not suspended, but its public annotation excludes
None. Update the TypeSpec to model the field as nullable and regenerate so list results are typed consistently with actual service responses.
suspension: "_models.AgentInsightSuspension" = rest_field(visibility=["read"])
"""Why the system suspended scheduled generation. Null when the monitor is not suspended.
Required."""
sdk/ai/azure-ai-projects/azure/ai/projects/operations/_patch_agent_insights.py:122
- The initial request receives
Foundry-Featuresthrough the beta-operation proxy, but that header is removed fromkwargsbefore this polling method is built.LROBasePollingsends status requests from its operation config, so subsequentOperation-Locationrequests omitAgentInsights=V1Previewand can be rejected by the preview endpoint. Pass the effectiveheadersmapping into the polling method, as the memory-store LRO does inoperations/_patch_memories.py:391-396.
LROBasePolling(lro_delay, path_format_arguments=path_format_arguments, **kwargs),
sdk/ai/azure-ai-projects/docs/public-methods.md:10
- The total only accounts for the 13 Agent Insights methods. This same regeneration adds three stable
AgentsOperationsmethods inapi.md—get_microsoft365_package,get_microsoft365_publish_defaults, andpublish_to_microsoft365—but this document still reports 55 stable methods, 23 agent methods, and omits all three from the method list. The totals should be 157 overall, 58 stable top-level methods, and 26 agent methods, with those methods added below.
There are a total of 154 unique public methods:
- 5 stable methods on the client
- 55 stable methods on top-level sub-clients
- 94 beta methods on nested beta sub-clients
sdk/ai/azure-ai-projects/tsp-location.yaml:2
- This changes the generation commit and adds three new TypeSpec directories, but the PR description is still the untouched template and does not explain the regeneration or link the corresponding
azure-rest-api-specsPR. Please update the PR metadata with the feature scope and source-spec PR so reviewers can validate the generated changes against their requirements.
- Files reviewed: 16/18 changed files
- Comments generated: 7
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines