Improve the UI Search settings

[adecler]

NOTE: Related to

Issues addressed by this PR

Closes #497

This fixes the issue highlighted in #497, that search item were excluded just because the word for an excluded toolkit was appearing somewhere in their textual representation. This PR fixes that by looking specifically at the part of the namespace that relates to the toolkit when excluding search items.

This PR also fixes a series of other issues discovered when working on this PR:

• The search setting file was re-opened every time a search was happening. This was highly inefficient so the filtering now happens a single time at start when loading the search item from the AssemblyContent file.
• This also fixed the fact that only the global menu was filtering out the excluded toolkits. Components menus were still showing the excluded toolkits.
• The search settings had their own UI window. This is different from any other settings in the BHoM since all other settings can be created using classic BHoM component. So I have removed the whole UI project but kept the bespoke access of the component from the ribbon to avoid confusion. This creates duplication with the fact that the settings can also be created from the CreateObject component but it is more user-friendly. We could also consider in the future to repurpose that component to create any settings so it makes sense to keep it for now.

Test files

• Just create a search setting using this script:

• You can check that the file was correctly created by looking at C:\ProgramData\BHoM\Settings\BH.oM.UI.SearchSettings.json
• You can then restart the UI (close Rhino) and check that the toolkits are now excluded from the search menus. Make sure to test both the global menu and the component menus.

Changelog

Additional comments

[adecler]

@BHoMBot check required

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[michaelhoehn]

Tested and approved. Happy with the functionality.

[bhombot-ci]

Please be advised that the check with reference 80862813320 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 1183 additional annotations waiting, made up of 1183 errors and 0 warnings.

[bhombot-ci]

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on Grasshopper_UI

[michaelhoehn]

@BHoMBot check core

[bhombot-ci]

@michaelhoehn to confirm, the following actions are now queued:

• check core

[michaelhoehn]

@BHoMBot check installer

[bhombot-ci]

@michaelhoehn to confirm, the following actions are now queued:

• check installer

[bhombot-ci]

@michaelhoehn to confirm, the following actions are now queued:

• check installer

[bhombot-ci]

@michaelhoehn to confirm, the following actions are now queued:

• check installer

[michaelhoehn]

@BHoMBot check serialisation

[bhombot-ci]

@michaelhoehn to confirm, the following actions are now queued:

• check serialisation

[michaelhoehn]

@BHoMBot check versioning

[bhombot-ci]

@michaelhoehn to confirm, the following actions are now queued:

• check versioning

[bhombot-ci]

@michaelhoehn to confirm, the following actions are now queued:

• check serialisation

There are 3 requests in the queue ahead of you.

[bhombot-ci]

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

[adecler]

@BHoMBot check versioning

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check versioning

There are 48 requests in the queue ahead of you.

[bhombot-ci]

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on Grasshopper_UI

[adecler]

@BHoMBot check versioning

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check versioning

There are 46 requests in the queue ahead of you.

[bhombot-ci]

@adecler to confirm, the following actions are now queued:

• check versioning

There are 45 requests in the queue ahead of you.

[bhombot-ci]

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on Versioning_Toolkit

[bhombot-ci]

@adecler just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @michaelhoehn on Versioning_Toolkit