XR Input - #138
Merged
Merged
Conversation
… what went wrong.
Closed
bghgary
approved these changes
Jan 27, 2020
bghgary
left a comment
bghgary
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. Probably should submit an issue to fix the TODOs in here.
Contributor
Author
|
For the |
CedricGuillemet
pushed a commit
to CedricGuillemet/BabylonNative
that referenced
this pull request
Feb 7, 2020
* At least able to detect the presence or absence of the controller. * WIP to bring input pose over to actual WebXR layer. * Seem to be sending out EXTREMELY rudimentary events properly. * Works! Including grip and aim space now. * Merged from master, but broken. Committing so I can try to figure out what went wrong. * Fixed. Almost certainly not optimal, but fixed. * Reverted change unintentionally checked in to JavaScript file. * Added _CRT_SECURE_NO_WARNINGS define to XR dependency folder. * Implementing a few TODOs and leftover features, as recommended from the PR. # Conflicts: # Library/Dependencies/xr/CMakeLists.txt
CedricGuillemet
added a commit
to CedricGuillemet/BabylonNative
that referenced
this pull request
Sep 2, 2026
9a569c7759 Merge pull request BabylonJS#144 from BabylonJS/bump/bgfx-swapchain2-guid 96add67bf0 Bump bgfx for IID_IDXGISwapChain2 GUID fix ede5513a6b Merge pull request BabylonJS#143 from BabylonJS/bump/bgfx-uwp-frame-latency 67b4b74122 Bump bgfx for UWP IDXGISwapChain2 frame-latency fix 1a135dbf90 Updated bgfx and bx. (BabylonJS#142) 9e56bab412 Updated bgfx, bimg and bx. (BabylonJS#141) 865b8e6afe Updated bgfx. (BabylonJS#140) 06755e6bb8 Updated bgfx, bimg and bx. (BabylonJS#139) f7333d92a0 Forward the remaining allocation-sizing BGFX_CONFIG_ settings (BabylonJS#138) e7773eed1d Honor BGFX_CONFIG_ settings set by a parent project (BabylonJS#137) 5c98749de4 Merge pull request BabylonJS#135 from BabylonJS/sergio/sse4-minspec-x86-slices 92961f9ac4 Updated bgfx and bimg. (BabylonJS#136) 9d89f09347 Apply bx's SSE4.2 minspec to every x86 target, not just x86_64 6c5515826c Don't let -Xarch_x86_64 break Apple builds that use -Werror. (BabylonJS#134) 7062f1109a Fix arm64 builds: Apple SSE minspec and MSVC ARM64 (BabylonJS#133) 44adc64c88 Updated bgfx and bx. (BabylonJS#131) 8f7e445593 Merge pull request BabylonJS#130 from SergioRZMasson/fix-x86_64-sse-minspec dd5bb1c019 Bump bx submodule to include the Windows platform.h fixes 191b723258 Propagate bx's x86_64 SSE4.2 minspec to the bx target 3b67f0c0c5 Updated bx, and bimg. (BabylonJS#129) 4c244b1a9f Updated bgfx, bimg, bx. (BabylonJS#128) git-subtree-dir: Dependencies/bgfx.cmake git-subtree-split: 9a569c775917e3dd2a8cfb8836aeddbe790a8deb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is by no means a fully-featured capability yet, but it should be in a good state for what it is, and it's now taken on something of the character of a bug fix. As of about two weeks ago, our XR capabilities broke in master because of changes made to Babylon.js, many of which had already been accounted for in this branch. My original plan had been to not check in this branch until I'd added a few more features (primarily buttons and controller models), but considering the circumstances I decided to alter that plan.