Added minimal change to allow v8 to shut down correctly. - #144
Merged
Conversation
bghgary
approved these changes
Jan 31, 2020
4 tasks
bkaradzic-microsoft
added a commit
that referenced
this pull request
Sep 1, 2026
…ings) (#1857) ## Summary Bumps `bgfx.cmake` to `9a569c775917e3dd2a8cfb8836aeddbe790a8deb` (bgfx `0837ead` via BabylonJS/bgfx#78 / bgfx.cmake#144) and adapts Babylon Native to the Graphics/shader packaging changes in that range. ### API adaptations - **Blit / read**: `encoder.blit` / `bgfx::blit` take `TextureRegion` pairs; `bgfx::readTexture` → `bgfx::read(TextureRegion, data)`. Updated in `FrameBuffer`, `DeviceImpl`, `NativeCapture`, `NativeEngine`. - **Shader binary v12**: `CreateBgfxShader` writes `BGFX_SHADER_BIN_VERSION = 12`, raw SRV/UAV masks, and per-uniform `texComponent` / `texDimension` / `texFormat`. Canvas precompiled headers bumped v11 → v12 accordingly. - **Vulkan v12 binding model**: rewrite glslang bindings to match shaderc (`Frame` UBO 0/1, images at `sharedBinding + 2`, samplers at `image + 16`); package `separate_images` with real `regIndex`. Shared `SamplerSplitter` bindings are preserved across VS/FS (not compacted per-stage). - **Depth RT formats**: depth-only FB prefers `D32F` → `D24` → `D24S8` (Android stays `D24S8`). Public `BackBufferDepthStencilFormat::Depth32` maps to `D32F` (plain `D32` has no DSV on D3D11/12). - **ShaderCache**: `CACHE_VERSION` 4 → 5 so stale v6/v11 packages are not served to bgfx v12. ### Upstream pins pulled in | Repo | Change | |------|--------| | BabylonJS/bgfx#77 | UWP: QI `IDXGISwapChain2` before `SetMaximumFrameLatency` | | BabylonJS/bgfx#78 | Define local `IID_IDXGISwapChain2` GUID (fix LNK2001) | | BabylonJS/bgfx.cmake#143/#144 | Submodule bumps for the above | ### Local validation (Win32 Debug) - Nested BBG, thin-instance / motion-blur suite: pass - Playground link after GUID fix: pass ### Test plan - [x] Configure + build Playground Debug (Win32) - [x] Headless Nested BBG + motion-blur / thin-instance suite - [x] CI full platform matrix (green on `14c0b36d`; re-run after this review fix) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: d47cbab2-d751-4cf9-984f-4412dd9ec601
CedricGuillemet
added a commit
to CedricGuillemet/BabylonNative
that referenced
this pull request
Sep 2, 2026
371d90098b Use zero depth to mean not a volume texture. (BabylonJS#150) b8cef564e3 texturec: Added positional arguments. (BabylonJS#149) 3b4baab012 Add BC4S, BC5S, BC6HU, RGB10A2U and D32FS8 texture formats. (BabylonJS#148) 0a64629d9f Updated tintexr. (BabylonJS#147) e95c449452 Updated stb_image. (BabylonJS#146) da38bface6 Fixed bounds check, and EXR channel pixel type. (BabylonJS#145) be16d98e34 Updated simplewebp. (BabylonJS#144) git-subtree-dir: Dependencies/bimg git-subtree-split: 371d90098b1fd017cd00205979d5ef74b8c3ed62
CedricGuillemet
added a commit
to CedricGuillemet/BabylonNative
that referenced
this pull request
Sep 2, 2026
9a569c7759 Merge pull request BabylonJS#144 from BabylonJS/bump/bgfx-swapchain2-guid 96add67bf0 Bump bgfx for IID_IDXGISwapChain2 GUID fix ede5513a6b Merge pull request BabylonJS#143 from BabylonJS/bump/bgfx-uwp-frame-latency 67b4b74122 Bump bgfx for UWP IDXGISwapChain2 frame-latency fix 1a135dbf90 Updated bgfx and bx. (BabylonJS#142) 9e56bab412 Updated bgfx, bimg and bx. (BabylonJS#141) 865b8e6afe Updated bgfx. (BabylonJS#140) 06755e6bb8 Updated bgfx, bimg and bx. (BabylonJS#139) f7333d92a0 Forward the remaining allocation-sizing BGFX_CONFIG_ settings (BabylonJS#138) e7773eed1d Honor BGFX_CONFIG_ settings set by a parent project (BabylonJS#137) 5c98749de4 Merge pull request BabylonJS#135 from BabylonJS/sergio/sse4-minspec-x86-slices 92961f9ac4 Updated bgfx and bimg. (BabylonJS#136) 9d89f09347 Apply bx's SSE4.2 minspec to every x86 target, not just x86_64 6c5515826c Don't let -Xarch_x86_64 break Apple builds that use -Werror. (BabylonJS#134) 7062f1109a Fix arm64 builds: Apple SSE minspec and MSVC ARM64 (BabylonJS#133) 44adc64c88 Updated bgfx and bx. (BabylonJS#131) 8f7e445593 Merge pull request BabylonJS#130 from SergioRZMasson/fix-x86_64-sse-minspec dd5bb1c019 Bump bx submodule to include the Windows platform.h fixes 191b723258 Propagate bx's x86_64 SSE4.2 minspec to the bx target 3b67f0c0c5 Updated bx, and bimg. (BabylonJS#129) 4c244b1a9f Updated bgfx, bimg, bx. (BabylonJS#128) git-subtree-dir: Dependencies/bgfx.cmake git-subtree-split: 9a569c775917e3dd2a8cfb8836aeddbe790a8deb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.