Don't use Napi::Persistent with Napi::String - #145
Merged
Conversation
syntheticmagus
approved these changes
Jan 31, 2020
CedricGuillemet
added a commit
to CedricGuillemet/BabylonNative
that referenced
this pull request
Sep 2, 2026
371d90098b Use zero depth to mean not a volume texture. (BabylonJS#150) b8cef564e3 texturec: Added positional arguments. (BabylonJS#149) 3b4baab012 Add BC4S, BC5S, BC6HU, RGB10A2U and D32FS8 texture formats. (BabylonJS#148) 0a64629d9f Updated tintexr. (BabylonJS#147) e95c449452 Updated stb_image. (BabylonJS#146) da38bface6 Fixed bounds check, and EXR channel pixel type. (BabylonJS#145) be16d98e34 Updated simplewebp. (BabylonJS#144) git-subtree-dir: Dependencies/bimg git-subtree-split: 371d90098b1fd017cd00205979d5ef74b8c3ed62
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 does not support persisting strings