More validation tests by CedricGuillemet · Pull Request #415 · BabylonJS/BabylonNative

CedricGuillemet · 2020-09-18T14:22:46Z

Because I like to make your life more difficult by adding validation tests ;)

26 more tests mostly gltf related
the validation test errorcode return was wrong. because of a wrong WM_
error tolerance boosted to 8% or 5% because of missing text in some scene.
success/failure task condition to push the appropriate artifact (results/errors)
Y flipped for RTT fixes Support render target textures #87
Post process!

bjs max with commit BabylonJS/Babylon.js@07ee198

bghgary · 2020-09-18T16:36:16Z

 var justOnce;
 var threshold = 25;
-var errorRatio = 2.5;
+var errorRatio = 8.0;


Is this higher than what Babylon.js uses now?

Yes! 2.5 bjs 8 here. Mostly because text is rendered in some PG.

I'm assuming you mean text is not being rendered because we don't have text rendering yet?

Yes! That's correct.

We discussed this offline. The plan is to update this value only for the tests that have text and put a comment somewhere that explains why (or, at a minimum, make sure the commit message says why).

…nto missingNativeFunctions

…met/BabylonNative into missingNativeFunctions

CedricGuillemet · 2020-09-22T15:14:34Z

Adding a bunch more test scenes this week. Back to draft.

…met/BabylonNative into missingNativeFunctions

…nto missingNativeFunctions # Conflicts: # Apps/BabylonScripts/babylon.max.js # Plugins/NativeEngine/Source/NativeEngine.cpp # Plugins/NativeEngine/Source/NativeEngine.h

removed 1 test (fail linux)

bghgary

Many of these changes are not ideal and should have issues associated with them. The API macros thing should be removed completely, but maybe after my changes.

bghgary · 2020-09-28T21:02:36Z

            break;
        }
-        case WM_DESTROY:
+        case WM_CLOSE:


Not sure about this one. I'm assuming you are seeing some shutdown issues. Usually the sequence is WM_CLOSE calls DestroyWindow which then causes WM_DESTROY which calls PostQuitMessage.

Replacing with direct errorCode for postquitmessage instead of using message param.

bghgary · 2020-09-28T21:03:35Z

-        case WM_DESTROY:
+        case WM_CLOSE:
        {
            short exitCode = LOWORD(wParam);


I'm a bit confused by this. Documentation says that the lParam and wParam of both WM_DESTROY or WM_CLOSE are not used. What does this do exactly?

bghgary · 2020-09-28T21:09:33Z

+target_compile_definitions(NativeEngine
+    PRIVATE API${GRAPHICS_API}) # OpenGL is defined in bgfx.h. Using APIXXX instead


I think this should probably be in all CAPS to match typical macros which may avoid the conflict. Use https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#string-transformations to convert to uppercase. But ideally, this shouldn't be done at all. The specific code should be in the specific files instead of using macros.

I agree we should not see any #ifdef platform anywhere in the code but in specific .cpp files. It's mostly in shaderCompilerCommon.cpp so I'll let you do the change when you are done with your shader compilation work.

bghgary · 2020-09-28T21:10:25Z

+        uint16_t height = static_cast<uint16_t>(info[2].As<Napi::Number>().Uint32Value());
+        bgfx::FrameBufferHandle frameBufferHandle{};
+
+        // This is WIP


Is there an issue to track?

bghgary · 2020-09-28T21:11:37Z

+                        0.f, 0.f, 1.f, 0.f,
+                        0.f, 0.f, 0.f, 1.f };
+                    bx::mtxMul(tmpMatrix, value.Data.data(), flipMatrix);
+                    bgfx::setUniform({ it.first }, tmpMatrix, value.ElementLength);


nit: clang format this code

…nto missingNativeFunctions # Conflicts: # Plugins/NativeEngine/Source/NativeEngine.cpp

080f466590 Added bx::hasUniqueObjectRepresentation type trait. (BabylonJS#420) 671a001d3e tinystl: reset() keeps the bucket table; clear() still shrinks to 9. (BabylonJS#419) 9f874936e2 Added ability to move file into trash. (BabylonJS#418) 9e3fadf6f1 Fixed floatFlip, SIMD variable-shift masks and %g precision, and added tests. (BabylonJS#417) 26ff6d907d MinGW: Fix sal. (BabylonJS#416) 0a09590ac8 Added positional arguments to CommandLine. (BabylonJS#415) 822be40688 Scanner: Class::Identifier must not start with a digit. (BabylonJS#414) 43bfe29402 Fixed DLL search order hijacking in dlopen. (BabylonJS#413) 0b001f5f36 MSVC: Added ARM64 target. (BabylonJS#412) 056ea3486c Scanner: Cleanup. (BabylonJS#411) 9916e720fc Added scanner. (BabylonJS#410) cd6720ce9a platform.h: detect MSVC ARM64 as 64-bit and raise 32-bit Windows minimum (BabylonJS#409) 5a2b876258 fromString: Parse hex float literals. (BabylonJS#408) a7257985fa Added bx::isEqual for bx::StringView. (BabylonJS#407) c98e98cde1 Fixed amalgamated build. (BabylonJS#406) ed183eb246 Allow files with 10k+ lines to align nicely. (BabylonJS#405) git-subtree-dir: Dependencies/bx git-subtree-split: 080f466590c161664f2a3c5d21e05bd31cc9c8c8

CedricGuillemet requested review from Drigax, bghgary and syntheticmagus September 18, 2020 14:22

More validation tests

ad70ced

CedricGuillemet force-pushed the moreValidationTests branch from e50e7e4 to ad70ced Compare September 18, 2020 14:29

CedricGuillemet added 5 commits September 18, 2020 17:07

test pipeline to get error images

178b670

yml

495527e

error artifacts

90ba253

removed touch

048d034

discard

13b691d

bghgary reviewed Sep 18, 2020

View reviewed changes

CedricGuillemet added 11 commits September 18, 2020 20:17

Merge branch 'master' into moreValidationTests

18ff182

Merge branch 'master' into moreValidationTests

bbaf2e6

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

db5070d

…nto missingNativeFunctions

bjs mac with empty texture for dynamic update

e4e11c6

removed linux check

815d173

Merge branch 'moreValidationTests' of https://github.com/CedricGuille…

d9573ad

…met/BabylonNative into missingNativeFunctions

new dummy png

db8b86f

32b png

f6fa17f

opengl shader revisited

7340ed6

Merge branch 'master' into moreValidationTests

e1087a7

pg root

99fe651

CedricGuillemet marked this pull request as draft September 22, 2020 15:14

CedricGuillemet added 6 commits September 23, 2020 09:55

Merge branch 'master' into moreValidationTests

f0f84f3

ES 300 for linux

0bf4009

Merge branch 'moreValidationTests' of https://github.com/CedricGuille…

f5be874

…met/BabylonNative into missingNativeFunctions

test post process

1448408

Y flip for RTT

aae0026

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

21c06a8

…nto missingNativeFunctions # Conflicts: # Apps/BabylonScripts/babylon.max.js # Plugins/NativeEngine/Source/NativeEngine.cpp # Plugins/NativeEngine/Source/NativeEngine.h

error ratio adjusted

ee78445

CedricGuillemet mentioned this pull request Sep 25, 2020

Add support for ShadowGenerator #398

Closed

CedricGuillemet added 2 commits September 25, 2020 14:20

spaces

1b56dc8

Do not use #ifdef ANDROID. Use APIOpenGL instead when suitable!

405e02d

CedricGuillemet marked this pull request as ready for review September 25, 2020 14:33

CedricGuillemet requested a review from bghgary September 25, 2020 14:33

CedricGuillemet added 4 commits September 28, 2020 18:00

added 9 more tests

b01fb4b

more reliable getimagedata

6885a5d

removed 1 test (fail linux)

removed ribbon morphing (linux fail)

665a01b

more time to test

ec6df9f

bghgary approved these changes Sep 28, 2020

View reviewed changes

CedricGuillemet added 10 commits September 29, 2020 10:26

clang format

9f7bafc

return of errorCode

af4cedd

Merge branch 'master' of https://github.com/BabylonJS/BabylonNative i…

9f093ca

…nto missingNativeFunctions # Conflicts: # Plugins/NativeEngine/Source/NativeEngine.cpp

removed freezing test on Linux

13bb84b

macos validation

1a98c7f

build ios

c427d71

VT cmake

b52a9e1

VT linux

f3ba37d

apple test paths

18e7c3f

output dir

806e736

CedricGuillemet merged commit 02c3474 into BabylonJS:master Sep 29, 2020

		target_compile_definitions(NativeEngine
		PRIVATE API${GRAPHICS_API}) # OpenGL is defined in bgfx.h. Using APIXXX instead

Uh oh!

Conversation

CedricGuillemet commented Sep 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bghgary Sep 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CedricGuillemet commented Sep 22, 2020

Uh oh!

bghgary left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CedricGuillemet commented Sep 18, 2020 •

edited

Loading

bghgary Sep 21, 2020 •

edited

Loading