Skip to content

Implement trip notifications and read state#449

Merged
thisismeonmounteverest merged 8 commits into
BeWelcome:developfrom
buyolitsez:340
Jul 6, 2026
Merged

Implement trip notifications and read state#449
thisismeonmounteverest merged 8 commits into
BeWelcome:developfrom
buyolitsez:340

Conversation

@buyolitsez

@buyolitsez buyolitsez commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

To close #340

  • notify nearby hosts when a member creates a new public trip
  • add a trip notification preference during signup/preferences
  • allow hosts to hide trips from their visitors lists
  • mark matching trip notifications as checked when a trip is hidden
telegram-cloud-photo-size-2-5330044562141026979-y telegram-cloud-photo-size-2-5330044562141026982-y telegram-cloud-photo-size-2-5330044562141027003-y

@thisismeonmounteverest thisismeonmounteverest left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buyolitsez Looks good. There are a few problems, though.

The notification needs to be on the subtrip as the reason for 'reading' a trip might be either the person it self or the time of the visit.

The notification tab is a left over from far, far away and will be removed in the near future so we do not need to worry about that anymore.

The original discussion was to allow for digests: Immediately, daily, weekly, monthly. Starting with immediately is fine for me, but with that in mind the code might need some tinkling.

To find the members to be informed we should make use of the new spatial indices for geonames, shouldn't we?

Do we want to allow members to 'read' a leg on the visitors page (/visitors) or only on the landing page?

Comment thread Migrations/Version20260626100000.php Outdated
Comment thread Migrations/Version20260626100000.php Outdated
Comment thread src/Controller/TripController.php Outdated
Comment thread src/Entity/MemberSubtripRead.php Outdated
Comment thread src/Entity/Preference.php Outdated
Comment thread src/Repository/SubtripRepository.php Outdated
Comment thread translations/missing/general.yaml
Comment thread translations/missing/preference.yaml Outdated
Comment thread translations/missing/trips.yaml Outdated
Comment thread Migrations/Version20260626100000.php Outdated
Comment thread src/Command/SendTripNotificationsCommand.php Outdated
Comment thread src/Entity/MemberTripNotificationSent.php Outdated
Comment thread src/Model/TripModel.php
Comment thread src/Model/TripModel.php Outdated
Comment thread src/Entity/Preference.php Outdated
Comment thread tests/Model/CreatedTripsRepository.php Outdated
Comment thread tests/Model/SentTripNotificationsRepository.php Outdated
Comment thread tests/Model/TripModelNotificationTest.php Outdated
Comment thread tests/Model/TripModelNotificationTest.php Outdated
@thisismeonmounteverest thisismeonmounteverest merged commit d9f47db into BeWelcome:develop Jul 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add notifications for trips and allow to mark trips as 'read'

2 participants