Add CraftEngineHook.getItemStack(id) lookup#2970
Merged
Merged
Conversation
Mirrors OraxenHook / ItemsAdderHook so addons can render the correct icon and display name for CraftEngine custom blocks in panels and GUIs without depending on CraftEngine directly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optional<ItemStack> CraftEngineHook.getItemStack(String id)so addons can resolve a CraftEngine custom-item ID to a realItemStack(with the correct texture / model data) without depending on CraftEngine directlyOraxenHook.getOptionalItemByIdandItemsAdderHook.getItemStackshape so addon code can branch by hook uniformlyWhy
The Level addon (and others) need to render custom blocks in GUIs. Oraxen and ItemsAdder both expose hook methods that return an
ItemStack; CraftEngine did not, so panels fell back toMaterial.PAPER. See BentoBoxWorld/Level#426.Implementation
Calls
CraftEngineItems.byId(Key.of(id))and, if the item is registered, returnscustomItem.buildItemStack()(the parameterless default onBuildableItem, which uses the empty build context).Test plan
./gradlew test— full suite passes./gradlew compileJava— compiles cleanly againstcraft-engine-bukkit:0.0.67/is valuepanel renders CraftEngine custom blocks with the correct icon and display name🤖 Generated with Claude Code