feat(zcash): add NU6.3 Ironwood signing metadata - #37
Closed
BitHighlander wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 30, 2026
Owner
Author
|
Superseded by the canonical upstream protocol change in keepkey#113. Closing this fork/package-version path so the firmware stack has one protocol source and one exact pin: f2246ce. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
NU6.3 activates the Ironwood value pool and transaction v6. The existing PCZT wire message could only identify Orchard and only carried the four v5 transaction component digests, so firmware could not safely distinguish or verify an Ironwood signing request.
Root cause
ZcashSignPCZThad no shielded-pool discriminator and no Ironwood component digest. Continuing to encode post-NU6.3 shielding as Orchard produces a negative Orchard value balance, which consensus now rejects.What changed
ZcashShieldedPoolenum with Orchard as wire-compatible defaultshielded_pooland the fifth v6ironwood_digestfield7.17.0for downstream hdwallet integrationImpact
Existing Orchard hosts remain wire-compatible because field 19 defaults to Orchard and all additions use new field numbers. Ironwood-capable hosts can now ask firmware to apply v6 digest and note-commitment rules.
Checks
npm run buildnpm pack --dry-run --cache /private/tmp/keepkey-npm-cache