Skip to content

feat(zcash): add NU6.3 Ironwood signing metadata #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BitHighlander wants to merge 1 commit into from
Closed

feat(zcash): add NU6.3 Ironwood signing metadata #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions messages-zcash.options
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ ZcashSignPCZT.transparent_digest max_size:32
ZcashSignPCZT.sapling_digest max_size:32
ZcashSignPCZT.orchard_digest max_size:32
ZcashSignPCZT.orchard_anchor max_size:32
ZcashSignPCZT.ironwood_digest max_size:32
ZcashSignPCZT.expected_seed_fingerprint max_size:32

ZcashPCZTAction.alpha max_size:32
Expand Down
10 changes: 10 additions & 0 deletions messages-zcash.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@

syntax = "proto2";

enum ZcashShieldedPool {
ZCASH_SHIELDED_POOL_ORCHARD = 0;
ZCASH_SHIELDED_POOL_IRONWOOD = 1;
}

// Sugar for easier handling in Java
option java_package = "com.keepkey.deviceprotocol";
option java_outer_classname = "KeepKeyMessageZcash";
Expand Down Expand Up @@ -44,6 +49,11 @@ message ZcashSignPCZT {
optional uint32 version_group_id = 16; // Version group ID
optional uint32 lock_time = 17; // Transaction lock time
optional uint32 expiry_height = 18; // Transaction expiry height
// NU6.3 / transaction-v6 Orchard-family pool selection. The existing
// orchard_* metadata fields describe the selected action bundle for wire
// compatibility; ironwood_digest is the fifth v6 transaction component.
optional ZcashShieldedPool shielded_pool = 19 [default = ZCASH_SHIELDED_POOL_ORCHARD];
optional bytes ironwood_digest = 20; // 32-byte Ironwood component digest (v6)
// Phase 3: transparent shielding support
optional uint32 n_transparent_outputs = 29; // 0 for shielded-only (default)
optional uint32 n_transparent_inputs = 30; // 0 for shielded-only (default), >0 for hybrid shielding tx
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@keepkey/device-protocol",
"version": "7.14.1",
"version": "7.17.0",
"publishConfig": {
"access": "public"
},
Expand Down