Potential fix for code scanning alert no. 3: Server-side request forgery#701
Merged
Conversation
Bump vite dependency from 7.3.1 to 7.3.3
Manage LICENSE file uploads and deletions
Add GNU AGPL v3 license
Prepare repository for open-source release and configure testing
Enhance README with Community section and reorganize documentation
Add automated GitHub Release workflow for version tags
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
Author
|
@claude can you code review the pr 701 and make any changes required |
… api.alternative.me The Copilot Autofix allowlist only included three hosts, but fetchJson() is also called with blockchain.info (BTC ticker) and api.alternative.me (Fear & Greed Index). Without these, address pages, wallet dashboard, and market page would throw "Disallowed provider URL" errors. Also moved the Set to module scope to avoid re-creating it on every call. https://claude.ai/code/session_01SKn49yBtsK4JtGvpyfauqB
9 tasks
Refactor: Extract allowed hosts to module-level constant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/BitSleuthAI/Analyzer/security/code-scanning/3
Use defense in depth:
fetchJson): parse the URL withnew URL, enforcehttps:and enforce hostname allowlist (blockstream.info,mempool.space,api.coingecko.com) before issuingfetch.getBlockDetails): validatehashformat and normalizestartIndexto a safe non-negative integer; URL-encodehashwhen interpolating.Best minimal fix without changing intended functionality:
src/lib/blockchain-api.ts, add URL validation at the top offetchJson.src/lib/mempool.ts, add strict block-hash regex (^[a-fA-F0-9]{64}$), sanitizestartIndex, and useencodeURIComponent(hash)in URLs.Suggested fixes powered by Copilot Autofix. Review carefully before merging.