fix agents reaping missing k8s jobs - #360
Merged
Merged
Conversation
9 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
What Changed
readAgentJobRunStatusByName()to classify one persisted Kubernetes Job by exact name, including a first-classmissingresult for 404s.reapOrphanedRuns()to immediately fail/release an external-lifecycle run when its persisted Job name is confirmed missing, bypassing the generic silence floor only for that exact 404 case.opencode_k8srun whose persisted Job is gone after a rollout.Verification
pnpm exec vitest run server/src/__tests__/heartbeat-process-recovery.test.ts— file collected successfully, but embedded Postgres tests were skipped on this host because the Postgres init script exited with code 1.pnpm --filter @paperclipai/server typecheckgit diff --checkRisks
external_run_idcontains a concrete Job name and an exact Kubernetes read returns 404.job_missing; that matches existing behavior for missing external-lifecycle jobs with no terminal status.Model Used
Checklist