[codex] fix post-restart missing Job slot stalls (BLO-17239) - #758
Merged
Conversation
Co-Authored-By: Paperclip <noreply@paperclip.ing>
|
🔗 Paperclip issue: BLO-17239 |
1 similar comment
|
🔗 Paperclip issue: BLO-17239 |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Author
|
@ally review |
|
Hey @kkroo! Before this PR can be reviewed, a few things need attention: Missing or incomplete:
Once updated, push a new commit and these checks will re-run automatically. — commitperclip |
Co-Authored-By: Paperclip <noreply@paperclip.ing>
Author
|
@ally review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
Linked Issues or Issue Description
Bug report (no matching GitHub issue exists):
NotFoundfor the persisted exact Job name and this worker has no adapter invocation finalizing the run, finalize it asjob_missingand release the reservation immediately.reapOrphanedRunswhile the run has fresh output.What Changed
NotFoundandactiveRunExecutionshas no local owner.Verification
pnpm --filter @paperclipai/server typecheckpnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-process-recovery.test.ts --testNamePattern='exact-missing Job|exact Job lookup'— 3 passedheartbeat-process-recovery.test.ts— all 144 test cases passed; the local process subsequently hit the suite's existing 120-second embedded-PostgreSQLafterAllcleanup timeoutgit diff --checkRisks
NotFoundand only when there is no in-process adapter owner.Model Used
Checklist
Fixes: #/Closes #/Refs #OR (b) described the issue in-PR following the relevant issue template