Fix word list speed in reader setup dialog#6
Merged
Conversation
Contributor
There was a problem hiding this comment.
Since we're trying to optimize here, would it save significant time to remember the current longest length? I don't know whether Java's implementation has to count the letters on each call to length...might not be significant, especially since most words are fairly short.
phillip-hopper
force-pushed
the
BL-523-b
branch
from
October 8, 2014 13:37
5f9e4dd to
5fc31b2
Compare
JohnThomson
added a commit
that referenced
this pull request
Oct 8, 2014
Fix word list speed in reader setup dialog
hatton
added a commit
that referenced
this pull request
Jun 26, 2026
#7949) Code changes responding to the PR review: - Team Collections (review #1/#3/#4/#13): BloomBridge's mutating external endpoints (add/update/process-book) now fail fast on a Team Collection rather than silently corrupting a shared collection (they don't honor checkout, the TeamCollection.status file, or TC renames). Adds CollectionModel.IsEditableCollectionATeamCollection and ExternalApi.RefuseIfTeamCollection, and documents the non-TC assumption on CollectionModel.AddBookFromFolder. - Off-screen JS bridge cleanup (#6/#7/#8) in BookProcessor: the capture trigger is now fire-and-forget (its result was discarded), the redundant Application.DoEvents() in the poll loop is removed (the sync call already pumps the loop), and WaitForJavascriptResult documents why the off-screen processor keeps the poll-a-window-global approach rather than the live editor's async API callback. - Async page-readiness (#10/#11/#15): SetImageDisplaySizeIfCalledFor now registers a requestPageContent delay around its asynchronous image-info fetch and resize, so captureContentForExternalProcessing waits for image sizing to finish before capturing. Corrects the editablePage.ts comments that wrongly called the load-time fix-ups "synchronous", and clarifies the natural-size fallback in autoFitImageOverTextSplits. - autoFit overlays (#14): fitOneImageOverTextSplit now also skips pages whose top pane has non-text overlays (canvas elements other than the background image), not just text overlays. - Smaller comment fixes: clarify the "already in the collection" guard in AddBookFromFolder (#2); document that the process-book overlay message is intentionally not localized (#12); note that priorForeground is captured once on purpose (#5); move the JSON-vs-delimiter note next to the code it describes (#16); raise the ExternalBusyOverlay z-index (#17). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
hatton
added a commit
that referenced
this pull request
Jul 10, 2026
Plan item 4. KeyboardResolver runs the per-machine cascade (pinned system -> pinned kmw -> Automatic: best OS match, else cached KMW fallback, else default) with a per-session ConcurrentDictionary cache (safe because keyboard changes require restart) and a background fetch of the top Keyman suggestion when Automatic finds no OS keyboard online - writing only CachedKmwFallbackKeyboard, marshalled to the UI thread and skipped while the settings dialog is open (plan risk #6). KeyboardingConfigApi drops all spike code and adds the real POST keyboarding/fieldFocused (handleOnUiThread): resolve, switch the OS keyboard only when the target differs from the last activation (never per keystroke), and reply the fixed contract the browser integration consumes. useKmw is true only when the keyboard is fully cached locally; otherwise it replies useKmw:false, activates default, and kicks a deduped background download so the next focus succeeds. CollectionKeyboardCache gains IsCached/GetFontUrl for the endpoint. Implemented by Claude Sonnet teammates under Claude Fable orchestration. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.