Skip to content

Add "Drag Images to Shadows" game page (BL-14650)#7006

Merged
StephenMcConnel merged 1 commit into
BloomBooks:Version6.2afrom
StephenMcConnel:BD-31-AddDragToShadowGame
Apr 23, 2025
Merged

Add "Drag Images to Shadows" game page (BL-14650)#7006
StephenMcConnel merged 1 commit into
BloomBooks:Version6.2afrom
StephenMcConnel:BD-31-AddDragToShadowGame

Conversation

@StephenMcConnel

@StephenMcConnel StephenMcConnel commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

This change is Reviewable

@StephenMcConnel StephenMcConnel changed the title Add "Drag Images to Shadows" game page (BD-31) Add "Drag Images to Shadows" game page (BL-14650) Apr 22, 2025
@StephenMcConnel
StephenMcConnel force-pushed the BD-31-AddDragToShadowGame branch 2 times, most recently from 948fbe4 to 3dc5b7e Compare April 23, 2025 16:35

@andrew-polk andrew-polk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @StephenMcConnel)


src/content/templates/template books/Games/Games.html line 860 at r2 (raw file):

                class="pageLabel"
                lang="en"
                data-i18n="TemplateBooks.PageLabel.DragImagesShadows"

I think we need to add this to the .xlf with translate="no"

@andrew-polk

Copy link
Copy Markdown
Contributor

src/content/templates/template books/Games/Games.html line 860 at r2 (raw file):

Previously, andrew-polk wrote…

I think we need to add this to the .xlf with translate="no"

Then, feel free to merge.

@StephenMcConnel
StephenMcConnel force-pushed the BD-31-AddDragToShadowGame branch from 3dc5b7e to 2256298 Compare April 23, 2025 17:11

@StephenMcConnel StephenMcConnel left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @andrew-polk)


src/content/templates/template books/Games/Games.html line 860 at r2 (raw file):

Previously, andrew-polk wrote…

Then, feel free to merge.

Done. Two other labels also needed to be added.

@StephenMcConnel
StephenMcConnel merged commit 86aeb3f into BloomBooks:Version6.2a Apr 23, 2025
@StephenMcConnel
StephenMcConnel deleted the BD-31-AddDragToShadowGame branch April 23, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants