Click a workspace tab by a test id, not by its localized label (BL-16799) - #8298
Merged
Conversation
TopBar.tsx rendered each tab as an <a role="tab"> with a localized label and no id, class or data-testid, so automation had to match the English text. Two costs, both already paid. src/BloomE2E/helpers/workspace.ts mapped tab ids to "Collections", "Edit" and "Publish", so the suite silently only worked in an English UI, which rules out automating the UI-language cases. And the component-tester's bloomExeCdp.ts drove "#main-tabs button", a selector that exists nowhere in the source, so bloom-exe-tabs.uitest.ts cannot have worked for some time: it needs a Bloom the developer already has running, and nothing ran it. Each tab now carries data-testid="workspace-tab-<id>", built from Bloom's own API name for the tab, and the tab strip carries data-testid="workspace-tabs". So switchTab and clickWorkspaceTab both take a tab id and need no map, and neither reads a label. Retires the AUTOMATION-DEBT.md entry "The top bar has no stable test ids, so tests match on localized text". Its "seen again" note stays: the Edit tab's page thumbnail menu still has no test ids, and that is not fixed here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
hatton
force-pushed
the
BL-16799-tab-test-ids
branch
from
September 3, 2026 19:40
a2f9a7e to
3c2d384
Compare
Master moved while this stack was open, so each branch merges the one below it. The conflicts were all in src/BloomE2E/AUTOMATION-DEBT.md: master gave the table of this stack a pull-request column and annotated each promise with its number, while this branch deletes its own row and replaces or deletes its own promise. The merge keeps both, taking this branch text where the two describe the same entry. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BaWw4EHWrbFF2fNJvMJVC8
Member
Author
|
[Claude Opus 5 from Hatton's machine during devin-review] Consulted Devin on 2026-09-03 22:45 UTC up to commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TopBar.tsx rendered each tab as an with a localized label and no
id, class or data-testid, so automation had to match the English text. Two
costs, both already paid. src/BloomE2E/helpers/workspace.ts mapped tab ids to
"Collections", "Edit" and "Publish", so the suite silently only worked in an
English UI, which rules out automating the UI-language cases. And the
component-tester's bloomExeCdp.ts drove "#main-tabs button", a selector that
exists nowhere in the source, so bloom-exe-tabs.uitest.ts cannot have worked
for some time: it needs a Bloom the developer already has running, and nothing
ran it.
Each tab now carries data-testid="workspace-tab-", built from Bloom's own
API name for the tab, and the tab strip carries data-testid="workspace-tabs".
So switchTab and clickWorkspaceTab both take a tab id and need no map, and
neither reads a label.
Retires the AUTOMATION-DEBT.md entry "The top bar has no stable test ids, so
tests match on localized text". Its "seen again" note stays: the Edit tab's
page thumbnail menu still has no test ids, and that is not fixed here.
This is one of eleven stacked pull requests (BL-16799)
Each one pays down one entry of
src/BloomE2E/AUTOMATION-DEBT.md, and each branches off the one before it. Base:BL-16799-shell-document. Review only this pull request's own commit; the ones below it are reviewed in their own pull requests. The first six change test and tooling code only; the last five also change product code.BL-16799-automation-scripts— Make the bloom-automation scripts safe to ask for helpBL-16799-vr-collect-failures— Report every failed image comparison in a visual-regression case, not the firstBL-16799-component-tests-in-ci— Run the component-tester Playwright suites nightlyBL-16799-vite-port— Let an e2e run test the working tree's front endBL-16799-type-in-one-call— Type into a text box in one call, not one key press per characterBL-16799-page-screenshot— Capture a whole book page from a testBL-16799-toolbox-registration— Register the toolbox tools from one list both callers shareBL-16799-shell-document— Stop a test attaching to a shell document Bloom does not driveBL-16799-tab-test-ids— Click a workspace tab by a test id, not by its localized labelBL-16799-page-change— Refuse a page change the Edit tab cannot do, and wait before askingBL-16799-collection-languages— Set a collection's languages through an e2e hook, not by writing XMLReplaces #8276, which did all of this in one pull request.
Verification of the whole stack, at its tip: the C# suite passes (3338 passed, 13 skipped), the front-end vitest suite passes (781 passed, 5 skipped), and the
src/BloomE2Esuite passes against a Vite dev server on the working tree (36 passed, 0 skipped, 8.2 minutes). Each pull request also has its own type check and lint.🤖 Generated with Claude Code
Devin review
This change is