Skip to content

Click a workspace tab by a test id, not by its localized label (BL-16799) - #8298

Merged
hatton merged 2 commits into
masterfrom
BL-16799-tab-test-ids
Sep 3, 2026
Merged

Click a workspace tab by a test id, not by its localized label (BL-16799)#8298
hatton merged 2 commits into
masterfrom
BL-16799-tab-test-ids

Conversation

@hatton

@hatton hatton commented Sep 3, 2026

Copy link
Copy Markdown
Member

TopBar.tsx rendered each tab as an with a localized label and no
id, class or data-testid, so automation had to match the English text. Two
costs, both already paid. src/BloomE2E/helpers/workspace.ts mapped tab ids to
"Collections", "Edit" and "Publish", so the suite silently only worked in an
English UI, which rules out automating the UI-language cases. And the
component-tester's bloomExeCdp.ts drove "#main-tabs button", a selector that
exists nowhere in the source, so bloom-exe-tabs.uitest.ts cannot have worked
for some time: it needs a Bloom the developer already has running, and nothing
ran it.

Each tab now carries data-testid="workspace-tab-", built from Bloom's own
API name for the tab, and the tab strip carries data-testid="workspace-tabs".
So switchTab and clickWorkspaceTab both take a tab id and need no map, and
neither reads a label.

Retires the AUTOMATION-DEBT.md entry "The top bar has no stable test ids, so
tests match on localized text". Its "seen again" note stays: the Edit tab's
page thumbnail menu still has no test ids, and that is not fixed here.

This is one of eleven stacked pull requests (BL-16799)

Each one pays down one entry of src/BloomE2E/AUTOMATION-DEBT.md, and each branches off the one before it. Base: BL-16799-shell-document. Review only this pull request's own commit; the ones below it are reviewed in their own pull requests. The first six change test and tooling code only; the last five also change product code.

  1. BL-16799-automation-scripts — Make the bloom-automation scripts safe to ask for help
  2. BL-16799-vr-collect-failures — Report every failed image comparison in a visual-regression case, not the first
  3. BL-16799-component-tests-in-ci — Run the component-tester Playwright suites nightly
  4. BL-16799-vite-port — Let an e2e run test the working tree's front end
  5. BL-16799-type-in-one-call — Type into a text box in one call, not one key press per character
  6. BL-16799-page-screenshot — Capture a whole book page from a test
  7. BL-16799-toolbox-registration — Register the toolbox tools from one list both callers share
  8. BL-16799-shell-document — Stop a test attaching to a shell document Bloom does not drive
  9. BL-16799-tab-test-ids — Click a workspace tab by a test id, not by its localized label
  10. BL-16799-page-change — Refuse a page change the Edit tab cannot do, and wait before asking
  11. BL-16799-collection-languages — Set a collection's languages through an e2e hook, not by writing XML

Replaces #8276, which did all of this in one pull request.

Verification of the whole stack, at its tip: the C# suite passes (3338 passed, 13 skipped), the front-end vitest suite passes (781 passed, 5 skipped), and the src/BloomE2E suite passes against a Vite dev server on the working tree (36 passed, 0 skipped, 8.2 minutes). Each pull request also has its own type check and lint.

🤖 Generated with Claude Code

Devin review


This change is Reviewable

TopBar.tsx rendered each tab as an <a role="tab"> with a localized label and no
id, class or data-testid, so automation had to match the English text. Two
costs, both already paid. src/BloomE2E/helpers/workspace.ts mapped tab ids to
"Collections", "Edit" and "Publish", so the suite silently only worked in an
English UI, which rules out automating the UI-language cases. And the
component-tester's bloomExeCdp.ts drove "#main-tabs button", a selector that
exists nowhere in the source, so bloom-exe-tabs.uitest.ts cannot have worked
for some time: it needs a Bloom the developer already has running, and nothing
ran it.

Each tab now carries data-testid="workspace-tab-<id>", built from Bloom's own
API name for the tab, and the tab strip carries data-testid="workspace-tabs".
So switchTab and clickWorkspaceTab both take a tab id and need no map, and
neither reads a label.

Retires the AUTOMATION-DEBT.md entry "The top bar has no stable test ids, so
tests match on localized text". Its "seen again" note stays: the Edit tab's
page thumbnail menu still has no test ids, and that is not fixed here.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@hatton
hatton force-pushed the BL-16799-tab-test-ids branch from a2f9a7e to 3c2d384 Compare September 3, 2026 19:40
Master moved while this stack was open, so each branch merges the one below it.
The conflicts were all in src/BloomE2E/AUTOMATION-DEBT.md: master gave the table
of this stack a pull-request column and annotated each promise with its number,
while this branch deletes its own row and replaces or deletes its own promise.
The merge keeps both, taking this branch text where the two describe the same
entry.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BaWw4EHWrbFF2fNJvMJVC8
@hatton

hatton commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

[Claude Opus 5 from Hatton's machine during devin-review]

Consulted Devin on 2026-09-03 22:45 UTC up to commit 1c917af290c286fcb15d5c77438b64f9033d7489.

Base automatically changed from BL-16799-shell-document to master September 3, 2026 23:11
@hatton
hatton merged commit cc4a149 into master Sep 3, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant