fix: populate optional area_type to all related functions#170
Merged
fix: populate optional area_type to all related functions#170
Conversation
dmuldrew
approved these changes
May 8, 2020
Collaborator
dmuldrew
left a comment
dmuldrew
left a comment
There was a problem hiding this comment.
Looks good! I made one these changes with the get_capacity function when working on change table output, but then realized I couldn’t use the functionality with the current mixing of states and load zone names in the current target spreadsheet.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The
area_typeparameter is added to functionarea_to_loadzone, however, it is not populated to the functions that callarea_to_loadzone.What is the code doing
populate optional area_type to all related functions.
Validation
All tests still passed.
Time to review
5mins