Skip to content

Develop into Master#410

Merged
ahurli merged 881 commits intomasterfrom
develop
Mar 16, 2021
Merged

Develop into Master#410
ahurli merged 881 commits intomasterfrom
develop

Conversation

@ahurli
Copy link
Copy Markdown
Contributor

@ahurli ahurli commented Mar 11, 2021

Merging Develop into Master, which will be tagged with a new release. See below for the release notes.

Closed Issues:

Merged pull requests (features):

Merged pull requests (fixes, etc.):

Jon Hagg and others added 30 commits November 3, 2020 11:55
Create an abstraction for a SSH connection to a remote data store
Add ability to scale gencost from change table
Add terms and conditions to ATTRIBUTION file
Add ability to scale generator Pmin via ChangeTable
@ahurli ahurli added this to the Put Your Records On milestone Mar 11, 2021
@ahurli ahurli requested review from kasparm and rouille March 11, 2021 00:49
@rouille
Copy link
Copy Markdown
Collaborator

rouille commented Mar 11, 2021

Thanks. I think it would be nice to include the release notes in the description of the PR as @danielolsen did for REISE.jl

@danielolsen
Copy link
Copy Markdown
Contributor

If the model branch is expected to get merged in the next day or two, should we try to get that into this release as well? That's a pretty major feature.

@rouille
Copy link
Copy Markdown
Collaborator

rouille commented Mar 11, 2021

If the model branch is expected to get merged in the next day or two, should we try to get that into this release as well? That's a pretty major feature.

We probably do.

@rouille
Copy link
Copy Markdown
Collaborator

rouille commented Mar 15, 2021

Looks very nice. Thanks! Would it be possible to add the last issues/PRs related to the grid model selection feature?

@ahurli
Copy link
Copy Markdown
Contributor Author

ahurli commented Mar 15, 2021

Done! Added in the new PRs/Issues. Note that both are ordered by number and not date closed, so the new PRs and Issues are embedded accordingly.

@ahurli ahurli closed this Mar 15, 2021
@ahurli ahurli reopened this Mar 15, 2021
@ahurli
Copy link
Copy Markdown
Contributor Author

ahurli commented Mar 16, 2021

Per conversation with Ben, I updated the list so that PRs that were not merged are excluded. I also filtered the PR list such that if any commit in the PR was listed as a "feat:", the PR was categorized as a feature PR. I think this should have caught most of the PRs with names that don't have that descriptor, but also has some interesting consequence that PRs like #94 or #239, which are named 'fix:' and 'chore:', have feature commits and are thus categorized as such. In these cases, is there a strong feeling of where to put them?

@rouille
Copy link
Copy Markdown
Collaborator

rouille commented Mar 16, 2021

I have changed the title of some PRs for clarity. You will have to rerun your scripts. i believe we will have to fix the following two entries manually:

Copy link
Copy Markdown
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@ahurli ahurli merged commit 59f1038 into master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants