fix: allow small tolerance on capacity factors#181
Merged
danielolsen merged 2 commits intodevelopfrom May 16, 2020
Merged
Conversation
danielolsen
force-pushed
the
fix_resource_cap_factor_tolerance
branch
from
218ebf0 to
7bff8db
Compare
dmuldrew
approved these changes
May 16, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Similarly to #128, we want to avoid an AssertionError that happens if the total generation is slightly above a capacity factor of 1. This can be seen when loading Scenario 519 and calling
CollaborativeStrategyManager.populate_targets_with_resources(), there is one region for which 'other' type generators have a calculated capacity factor of 100.01%, and this halts the method.What is the code doing
Adding a small tolerance (1e-3 by default) to the
0 < x < 1check.Time to review
5 minutes.