Conversation
rouille
reviewed
Aug 5, 2020
rouille
reviewed
Aug 5, 2020
rouille
reviewed
Aug 5, 2020
rouille
reviewed
Aug 5, 2020
rouille
approved these changes
Aug 5, 2020
Collaborator
rouille
left a comment
rouille
left a comment
There was a problem hiding this comment.
This looks good. Thanks.
BainanXia
approved these changes
Aug 6, 2020
Collaborator
BainanXia
left a comment
BainanXia
left a comment
There was a problem hiding this comment.
This is nice. Thanks.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Create abstraction for execute list by having any reads/writes go through a central location.
What the code does
Follow same pattern as #240
Time to review
~20 mins. Integration tests pass and I manually checked I can still load a scenario which downloads the execute list, not sure about testing other code paths since they are destructive (would need to override the file location to do a real test scenario).