Conversation
Collaborator
|
@kasparm and @BainanXia, can look at this PR? I think you have already everything set up on your machine or the server. This should be not much work to checkout the branch and run the test. |
BainanXia
approved these changes
Aug 28, 2020
Collaborator
BainanXia
left a comment
There was a problem hiding this comment.
All tests passed. Tables for testing purpose are created automatically once the the container is up. Thanks.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Simplify local integration tests by automating schema creation in local db.
What it does
Add
schema.sqlto git, and mount it in the local db container. Postgres will automatically run the scripts in/docker-entrypoint-initdb.dwhich eliminates the need to any manual db management in this case.To test this, I removed the existing containers (
docker-compose -f stack.yml downanddocker container prune) then recreated them and logged in usingpsqlto verify.Time to review
5 min