feat: add method to check progress of ongoing simulation#387
Merged
Conversation
Collaborator
Author
|
Some selected output from testing, for completeness |
Collaborator
That is nice |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add a method to check the status endpoint in the reisejl api. This is provided for docker users to get more detailed output without having a separate shell in the server container.
What the code is doing
Other than the new method, added some basic validation on the deployment mode in the extract call since we have it defaulted to automatic when launched via the api.
Testing
Manual testing. Built the containers, launched a simulation, called
check_progress.Time estimate
5 min
Note: I am not that excited to have the environment dependent functionality here, but plan on consolidating it in the future, and keeping it limited.