refactor: move generation of matfile to separate function#406
refactor: move generation of matfile to separate function#406danielolsen merged 1 commit intodevelopfrom
Conversation
|
I would create a new module in PowerSimData/input next to grid.py since it can be used outside the scenario framework and it is an input of the simulation |
Propose a location and I will move it. I have no attachment to the current one, I just wanted to decouple the function somehow. Wherever we put it, it would probably be good to have a convenience method on the Grid object that calls the function. |
48d7520 to
866fcb8
Compare
I would wait that |
Once a Grid is instantiated, does it matter where it came from in order to write the tables into a matfile? |
No it does not. I said to wait because we did quite some modifications in the |
I am not in a particular rush. I needed to do this for some of my own work, and I used an ugly workaround, and in the process I saw how simple the change could be so I decided to get the ball rolling on a PR. |
866fcb8 to
ecfa4fd
Compare
ecfa4fd to
153bdfa
Compare
Purpose
Decouple the matfile generation from the client/server setup. Closes #364.
What the code is doing
Code doesn't functionally change, it's just reorganized.
Testing
Not tested yet to prepare a scenario, but tested for creating a matfile from a base grid.
Usage Example/Visuals
Time estimate
5 minutes to understand, maybe longer to decide exactly where you think this should live.