GAUD-10486: recalculate dropdown shadows when content changes - #7321
Merged
Conversation
dlockhart
commented
Aug 5, 2026
| { name: 'async-content-added', initialContent: 'Initial Content', asyncContent: scrollContent }, | ||
| { name: 'async-content-removed', initialContent: scroll, asyncContent: 'Updated' } | ||
| { name: 'async-content-added', initialContent: unsafeHTML(noScrollContent), asyncContent: scrollContent }, | ||
| { name: 'async-content-removed', initialContent: scroll, asyncContent: noScrollContent } |
Member
Author
There was a problem hiding this comment.
Unfortunately I had to tweak these slightly so that the width of the content remained the same. Otherwise the shadows wouldn't span the full width.
dlockhart
marked this pull request as ready for review
August 5, 2026 21:23
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dbatiste
approved these changes
Aug 6, 2026
|
🎉 This PR is included in version 3.286.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from adding the tests in #7319, this adds a resize observer around the dropdown content. When it triggers, the scroll shadows are recalculated.
This does solve the narrow use case where the content/dropdown width doesn't resize. If the width does change, the shadow still doesn't span the full width. That's a bigger can of worms, but I felt like this fix on its own was still useful.
Vdiff Report