GAUD-10486: delay scroll calculation - #7337
Merged
Merged
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
svanherk
approved these changes
Aug 7, 2026
|
🎉 This PR is included in version 3.287.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #7321 merged, two filter vdiffs starting being very flaky, occasionally showing a shadow in the dropdown when there shouldn't have been one.
I dug into this pretty deeply, and what I was seeing was that the dropdown container's
scrollHeightwas sometimes8pxtaller than itsclientHeightfor a very brief period of time after the resize observer fired. This happened about 25% of the time for me locally. I can only assume that it sometimes takes some time for it to reflect reality.This wasn't an issue before #7321 because the shadows were being calculated only once and it was happening way before any of the content in the dropdown had rendered.