Skip to content

Bugfix: extpar_art_to_buffer.py - #452

Merged
stelliom merged 2 commits into
masterfrom
debug_dwd
Jul 8, 2026
Merged

Bugfix: extpar_art_to_buffer.py#452
stelliom merged 2 commits into
masterfrom
debug_dwd

Conversation

@sbrand-dwd

Copy link
Copy Markdown
Collaborator

Description

A bug in the call of python modules within script extpar_art_to_buffer.py was corrected. We also ensure that an extpar image file is created and uploaded do Docker Hub for branch 'debug_dwd'. Thus, DWD's local Zonda installation can be updated with this image file and tested.

Workflow for merging PRs

Please read these instructions carefully and follow the steps below before requesting a review by the maintainers. This way we can ensure a smoother review process and your changes will be merged sooner.

Additionally, if this is the first PR you open in EXTPAR make sure to read the "Information for EXTPAR Developers" section in the documentation.

Checklist

  • Provide a detailed description of your changes in the "Description" section above.
  • If you implemented a new feature:
    • Document it in the correct Markdown file(s) under the docs/ directory.
    • Add a new test or make sure your changes are already tested.
  • Your code follows the style guidelines.
  • Your changes only touch the files/lines relevant for you.
  • All four required checks pass (see "Testing and debugging" for more details).
  • No conflicts with the base branch.

If all the points above are satisfied you can ask for a review by selecting stelliom as a reviewer.

For any questions please ping @stelliom on this PR.

Testing and debugging

The most important test for PRs is the one labeled "EXTPAR Testsuite on Jenkins". This checks that the results of all testcases (described by the namelists in test/testsuite/data) did not change compared to the references.

You can launch the testsuite by writing launch jenkins as a comment in the PR that you want to test. Once completed, the result of the testsuite will be shown on the PR (failure or success).

If you need more details on the testsuite results (e.g., if you are trying to debug an error or you are simply unsure why the tests fail) you can launch the testsuite with launch jenkins(debug). This will run the tests as usual, but, once completed, you will be given a URL (via a comment on the PR) to access the logfiles and namelists of all tests that were run.

@sbrand-dwd

Copy link
Copy Markdown
Collaborator Author

launch jenkins

@sbrand-dwd
sbrand-dwd requested a review from stelliom July 8, 2026 07:47
@stelliom

stelliom commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

All good, but I need to remove the branch from the deployment list. Once it's merged you can use the image of the main branch. It usually takes 30/40 mins to generate the new image after the merge.

@sbrand-dwd

Copy link
Copy Markdown
Collaborator Author

Thanks.

@stelliom stelliom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! Thanks a lot!

@stelliom
stelliom merged commit 6136cf9 into master Jul 8, 2026
3 checks passed
@stelliom
stelliom deleted the debug_dwd branch July 8, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants