Skip to content

[FIX] Initialise timing for MP4 webvtt. #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cfsmp3 merged 1 commit into from
Jul 14, 2017
Merged

[FIX] Initialise timing for MP4 webvtt. #754

cfsmp3 merged 1 commit into from
Jul 14, 2017

Conversation

@saurabhshri
Copy link
Member

@saurabhshri saurabhshri commented Jul 14, 2017

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Fixes #753 .

@canihavesomecoffee
Copy link
Member

canihavesomecoffee commented Jul 14, 2017

Fails are expected on winodws, can be merged 👍

@cfsmp3 cfsmp3 merged commit 45946e3 into CCExtractor:master Jul 14, 2017
hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Mar 12, 2025
@dependabot
Bump markdown2 from 2.4.5 to 2.4.8 (CCExtractor#754)
db690b9 
Bumps [markdown2](https://github.com/trentm/python-markdown2) from 2.4.5 to 2.4.8.
- [Release notes](https://github.com/trentm/python-markdown2/releases)
- [Changelog](https://github.com/trentm/python-markdown2/blob/master/CHANGES.md)
- [Commits](trentm/python-markdown2@2.4.5...2.4.8)

---
updated-dependencies:
- dependency-name: markdown2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Can't extract WEBVTT Closed Captions

3 participants

@saurabhshri @canihavesomecoffee @cfsmp3