Conversation
jeremylt
force-pushed
the
jeremy/min-petsc
branch
from
c62e010 to
b896299
Compare
Member
Author
|
Updated to set https://gitlab.com/petsc/petsc/-/commit/0e95d8424937f5c91c24c9ee84bd617c5e0333ee as the minimum PETSc dev commit. |
jedbrown
approved these changes
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the minimum version of PETSc to v3.17 and mentions https://gitlab.com/petsc/petsc/-/commit/3aa6300419c71e062c3b79f2357c12af68281a1b
This commit will be the minimum required once we merge #807, though we may need to push that out again after https://gitlab.com/petsc/petsc/-/merge_requests/4786
I am not wild about repeating this version number in 3 places, but it feels like the easiest way to communicate the requirement and the version number should change very infrequently.