React migration: ItemDetails + CommentItem components#439
Merged
devin-ai-integration[bot] merged 1 commit intoJul 8, 2026
Merged
Conversation
Co-Authored-By: Devanshi Gupta <devanshi.gupta@cognition.ai>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
8ff5078
into
devin/1783534263-react-migration
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the Angular
ItemDetailsComponentand recursiveCommentComponentto React, replacing the existing stubs.ItemDetails.tsx: fetches a story viafetchItemContent(itemID)in auseEffectkeyed onitemID(withwindow.scrollTo(0,0)), rendering<Loader />while pending and<ErrorMessage message="Could not load item comments." />on failure. Preserves the original template structure: mobile header with a back button (navigate(-1)), laptop header (conditionalitem-header/head-marginclasses), poll results withpollBarwidthpoints/poll_votes_count*100%, subject viadangerouslySetInnerHTML, and acomment-listof<CommentItem />. External-vs-internal title link keys offhasUrl = item.url.indexOf('http') === 0;openLinkInNewTabfromuseSettings()controlstarget/rel.CommentItem.tsx: recursive component with localcollapsestate. Renders[+]/[-]toggle, user<Link>,time_ago,comment-text(innerHTML), and recurses overcomment.commentsinto asubtree. Deleted comments render the[deleted]meta. NamedCommentItemto avoid clashing with theCommentmodel type.@importpaths rebased to../shared/scss/...and:host >>>wrappers dropped.npm run build(tsc + vite) andnpm run lintboth pass with no errors/warnings. No files outsidesrc/item-details/were touched.Link to Devin session: https://app.devin.ai/sessions/f2735a4278f142dcb87cb5c2422a3edb
Requested by: @devanshi-gpta
Devin Review