Skip to content

feat: better style of network link panel #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codeflight1 merged 1 commit into from
Jul 18, 2026
Merged

feat: better style of network link panel #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 51 additions & 82 deletions src/components/panels/NetworkHealthTelemetryPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,6 @@
import React, { useEffect, useState } from "react";
import ROSLIB from "roslib";
import { useROS } from "@/ros/ROSContext";
import {
BarChart,
Bar,
XAxis,
YAxis,
Tooltip,
ResponsiveContainer,
Cell,
LabelList,
} from "recharts";

const dotStyle = (up: boolean): React.CSSProperties => ({
width: 12,
Expand Down Expand Up @@ -177,23 +167,45 @@ const NetworkHealthTelemetryPanel: React.FC = () => {

const toMbps = (bitsPerSecond: number) => bitsPerSecond / 1_000_000;

const throughputData = [
const telemetryRows = [
{
name: "TX",
Throughput: toMbps(stats.throughputTx),
Capacity: toMbps(stats.bandwidthTx),
name: "Signal Strength",
value: stats.signalStrength.toFixed(2),
unit: "dBm",
good: stats.signalStrength > -70 && stats.signalStrength < -20,
},
{
name: "RX",
Throughput: toMbps(stats.throughputRx),
Capacity: toMbps(stats.bandwidthRx),
name: "Noise Floor",
value: stats.noiseFloor.toFixed(2),
unit: "dBm",
good: stats.noiseFloor < -85,
},
{
name: "CCQ TX",
value: stats.ccqTx.toFixed(2),
unit: "%",
good: stats.ccqTx >= 90,
},
{
name: "Downlink",
value: `${toMbps(stats.throughputTx).toFixed(2)} / ${toMbps(
stats.bandwidthTx
).toFixed(2)}`,
unit: "Mbps",
good:
stats.bandwidthTx > 0 &&
stats.throughputTx / stats.bandwidthTx < 0.8,
},
Comment thread
ConnorNeed marked this conversation as resolved.
{
name: "Uplink",
value: `${toMbps(stats.throughputRx).toFixed(2)} / ${toMbps(
stats.bandwidthRx
).toFixed(2)}`,
unit: "Mbps",
good:
stats.bandwidthRx > 0 &&
stats.throughputRx / stats.bandwidthRx < 0.8,
},
Comment thread
ConnorNeed marked this conversation as resolved.
];

const telemetryRows = [
{ name: "Signal Strength", value: stats.signalStrength.toFixed(2), unit: "dBm" },
{ name: "Noise Floor", value: stats.noiseFloor.toFixed(2), unit: "dBm" },
{ name: "CCQ TX", value: stats.ccqTx.toFixed(2), unit: "%" },
];

return (
Expand All @@ -212,25 +224,25 @@ const NetworkHealthTelemetryPanel: React.FC = () => {
<table style={{ width: "100%", borderCollapse: "collapse" }}>
<thead>
<tr>
<th style={{ textAlign: "left", padding: "8px", borderBottom: "1px solid #333" }}>
<th style={{ textAlign: "left", padding: "4px 8px", borderBottom: "1px solid #333" }}>
Host
</th>
<th style={{ textAlign: "right", padding: "8px", borderBottom: "1px solid #333" }}>
<th style={{ textAlign: "right", padding: "4px 8px", borderBottom: "1px solid #333" }}>
RTT (ms)
</th>
<th style={{ textAlign: "center", padding: "8px", borderBottom: "1px solid #333" }}>
<th style={{ textAlign: "center", padding: "4px 8px", borderBottom: "1px solid #333" }}>
Status
</th>
</tr>
</thead>
<tbody>
{pingRows.map((r) => (
<tr key={r.name}>
<td style={{ padding: "8px", borderBottom: "1px solid #222" }}>{r.name}</td>
<td style={{ padding: "8px", textAlign: "right", borderBottom: "1px solid #222" }}>
<td style={{ padding: "4px 8px", borderBottom: "1px solid #222" }}>{r.name}</td>
<td style={{ padding: "4px 8px", textAlign: "right", borderBottom: "1px solid #222" }}>
{r.rttMs === -1 ? "Offline" : r.rttMs}
</td>
<td style={{ padding: "8px", textAlign: "center", borderBottom: "1px solid #222" }}>
<td style={{ padding: "4px 8px", textAlign: "center", borderBottom: "1px solid #222" }}>
<span style={dotStyle(r.up)} />
</td>
</tr>
Expand All @@ -243,75 +255,32 @@ const NetworkHealthTelemetryPanel: React.FC = () => {
<table style={{ width: "100%", borderCollapse: "collapse" }}>
<thead>
<tr>
<th style={{ textAlign: "left", padding: "8px", borderBottom: "1px solid #333" }}>
<th style={{ textAlign: "left", padding: "4px 8px", borderBottom: "1px solid #333" }}>
Metric
</th>
<th style={{ textAlign: "right", padding: "8px", borderBottom: "1px solid #333" }}>
<th style={{ textAlign: "right", padding: "4px 8px", borderBottom: "1px solid #333" }}>
Value
</th>
<th style={{ textAlign: "center", padding: "4px 8px", borderBottom: "1px solid #333" }}>
Status
</th>
</tr>
</thead>
<tbody>
{telemetryRows.map((row) => (
<tr key={row.name}>
<td style={{ padding: "8px", borderBottom: "1px solid #222" }}>{row.name}</td>
<td style={{ padding: "8px", textAlign: "right", borderBottom: "1px solid #222" }}>
<td style={{ padding: "4px 8px", borderBottom: "1px solid #222" }}>{row.name}</td>
<td style={{ padding: "4px 8px", textAlign: "right", borderBottom: "1px solid #222" }}>
{row.value} {row.unit}
</td>
<td style={{ padding: "4px 8px", textAlign: "center", borderBottom: "1px solid #222" }}>
<span style={dotStyle(row.good)} />
</td>
Comment thread
ConnorNeed marked this conversation as resolved.
</tr>
))}
</tbody>
</table>
</div>

<div
style={{
background: "#1e1e1e",
color: "#f1f1f1",
padding: "1rem",
height: "100%",
overflowY: "auto",
display: "flex",
flexDirection: "column",
}}
>
<div style={{ height: "125px" }}>
<ResponsiveContainer width="100%" height="100%">
<BarChart data={throughputData} layout="vertical" margin={{ top: 20, right: 30, left: 20, bottom: 5 }}>
<XAxis
type="number"
domain={[0, (dataMax: number) => Math.max(1, Math.floor(dataMax * 1.2))]}
stroke="#ccc"
tick={{ fill: "#ccc" }}
/>
<YAxis
type="category"
dataKey="name"
stroke="#ccc"
tick={{ fill: "#ccc" }}
/>
<Tooltip
contentStyle={{ backgroundColor: "#333", border: "none", color: "#fff" }}
labelStyle={{ color: "#ddd" }}
/>
<Bar dataKey="Capacity" fill="#4b5563" barSize={24} />
<Bar dataKey="Throughput" fill="#3b82f6" barSize={16}>
<LabelList dataKey="Throughput" position="right" fill="#f1f1f1" />
{throughputData.map((entry, index) => (
<Cell
key={`cell-${index}`}
fill={
entry.Capacity > 0 && entry.Throughput / entry.Capacity > 0.85
? "#ef4444"
: "#3b82f6"
}
/>
))}
</Bar>
</BarChart>
</ResponsiveContainer>
</div>
</div>
</div>
);
};
Expand Down
Loading