[RM] Save/load times #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7929056.
1zc
requested changes
Jan 1, 2024
1zc
requested changes
Jan 4, 2024
* Inherit Checkpoint object, replace RunTime with Ticks * Fix errors with creating new Checkpoint * Simplify PersonalBest base class by excluding ID and Rank from constructor
* Tidy up player stats classes * Move Checkpoints load method to PlayerStats * Use info_teleport_destinations for player spawn locations * Look for info_teleport_destinations with guideline names * Fallback if associated info_teleport_destination cannot be found * Append `spawn_` to info_teleport_destination standards * Resolve warnings
* Test commit, fix stages * Add files via upload * Updated * Delete src/bin/Debug/net7.0 directory * . * whoopsie? * quick review * Updated replay to work with bots - Fixed bot spamming errors with the TriggerStartZone/TriggerEndZone - Added reverse/pause replay (!rr/!rp) Still need to fix more bots than wanted joining, and make DB queries async * Working replays, not 100% done * Fixed bot spawning rate, TODO: * UPDATED: Default surf config to right configs TODO: Add stage/bonuses/etc support when done, update bot_quota to change upon loading map time * Bot changes name on replay loading * Used FormatTime in necessry places. Added cool HUD when spectating replays. Added css_spec/css_replaybotpause/css_replaybotflip * Fixed, error when no replay data --------- Co-authored-by: Shachar <shachar262@gmail.com> Co-authored-by: T <74899888+tslashd@users.noreply.github.com> --------- Bots rely on this ws-cs2/CS2Fixes@2380ec6 otherwise we get some wonky angles while the bot is surfing
…onus support (#10) * Fixed bot noclipin when no replay * Added saveloc/tele support * Added practice mark to messages when in practice mode * Now even when time not running, When tele it will start playing in practice mode * Forgot to add the tele args lol, Fixed now * Fixed error when !tele <num> larger than amount of teles or not a number * Fixed Map stages counting. why wasn't this fix already :( * Added support for more than one replay bot + plugin no longer relies on Will's version of cs2fixes * Displaying time instead of ticks in bot replay now. would like for someone to check if there is a better way, but this works pretty well * Added support for Personal Best replays with !pbreplay <maptime_Id/null> * Updated readme * Removed not needed comments * Works also when no wr exists * FormatTime correctly * Reverted uneeded changes * Temp patch for maps changing bot_quota, need to be addressed * Cleaned code
1zc
reviewed
Jan 24, 2024
Member
|
Other than that, happy to merge so we can continue work based on the dev branch. Thanks a lot @tslashd @shacharrr |
1zc
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompactnowUses an updated DB Schema (cs2_surftimer.txt) which will most likely change again
RunTimestill needs to be addressed in this PRStartandEndvelocities in order to be able to calculate the "client wanted speed" (XY, XYZ, etc.) when that becomes a thingDictionarywith key the Checkpoint numberPersonalBestso it should be good for Checkpoints/Stages? 🤔Isto boolsMap StartandMap End) in HUD on touching said zones!scommand = brokege!s 6and!s 7send you to the same stage (tested onsurf_beginnner)WrRunCheckpointsdictionary toMap.csso we can load the WR checkpoints inside of it for comparisons ? (Mapclass now has aPersonalBestobject associated with it for WRs)CurrentMapaccessible insidePlayerStats.csinstead of passing arguments ?CurrentMapaccessible insidePlayerHUD.csso that we can showMap Record TimeandMap Completionsreplay_frameseven more and store them inMapTimes(directly attached to the run)Still to be done
asyncdatabase queriesCheckpoints (CurrentRun) to the database should be made with TransactionsPluginPrefixaccessible insidePlayerHUD.csinstead of passing arguments ?SaveMapTimehas the ability tore-loadcheckpoints, but we need to makeLoadMapTimesDataaccessible in there as wellLoadMapTimesDatato be called from here as well, otherwise we may not have the correctthis.IDpopulatedSpecial thanks to @shacharrr for jumping on board and helping out with the Surf Initiative