Merged
Conversation
|
|
||
| } | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
- getInitState() is not needed since it returns {}. export function reducer(state={}, action={}) should be fine.
- console.error should change to logError instead.
- Is any reason that some places the function expressions are used and other places function declarations are used?
Contributor
There was a problem hiding this comment.
The reason for logError is that is shows stack traces by default and give us a place to upgrade our error logging when we want. It is a very simple function but all error logging should go through it.
A little more when used from a promise... when passing an error that is passed to the catch you really want to see the error stack where the error occurred, not the stack trace of the catch. That is what logError does.
Contributor
Author
There was a problem hiding this comment.
Thank you for the comments. I followed your suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When zooming decimated data, a request should go to the server to fetch zoomed data. If the result is not decimated, further zoom does not require server call, but restoring the original does. Hence we need to remember if the unzoomed data were decimated or not.