Skip to content

DM 4788#26

Merged
lznakano merged 1 commit intodevfrom
DM-4788
Mar 2, 2016
Merged

DM 4788#26
lznakano merged 1 commit intodevfrom
DM-4788

Conversation

@lznakano
Copy link
Copy Markdown
Contributor

@robyww : please review it. Thanks!

@robyww
Copy link
Copy Markdown
Contributor

robyww commented Mar 1, 2016

Small UI Stuff:

  • don't clear the label, only clear the value - it looks less flashy
  • don't make the label look like a link.

@robyww
Copy link
Copy Markdown
Contributor

robyww commented Mar 1, 2016

I think you have the right concept. I think it is working correctly. Most of the comments are just small stuff. The only major thing is, I don't think you need componentDidMount or componentWillUnmount. Make sure you have eslint running in IntelliJ.

Otherwise, Good Job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants