fix: preserve teleprompter scroll position when resuming playback (#2081) - #2088
Open
Samarth1306w wants to merge 4 commits into
Open
fix: preserve teleprompter scroll position when resuming playback (#2081)#2088Samarth1306w wants to merge 4 commits into
Samarth1306w wants to merge 4 commits into
Conversation
…ack endpoints and add contract test (CapSoftware#2039)
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
Comment on lines
+6
to
+7
| // Rate limit IDs declared in advance for firewall rules or separate app packages | ||
| // that are intentionally not yet wired in apps/web endpoints. |
Contributor
There was a problem hiding this comment.
This comment restates the purpose already conveyed by UNWIRED_RATE_LIMIT_IDS, adding maintenance noise contrary to the repository's explicit comment policy.
Suggested change
| // Rate limit IDs declared in advance for firewall rules or separate app packages | |
| // that are intentionally not yet wired in apps/web endpoints. |
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/__tests__/unit/rate-limit-ids.test.ts
Line: 6-7
Comment:
**Redundant descriptive comment**
This comment restates the purpose already conveyed by `UNWIRED_RATE_LIMIT_IDS`, adding maintenance noise contrary to the repository's explicit comment policy.
```suggestion
```
**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2081
Summary
Greptile Summary
This PR preserves teleprompter playback position across desktop and mobile layout updates and adds rate limiting to public analytics and guest-checkout endpoints.
Confidence Score: 4/5
The PR appears safe to merge, with only a non-blocking repository comment-policy violation in the new unit test.
The teleprompter state-preservation and endpoint rate-limiting changes have no established behavioral defect; the sole accepted concern is redundant descriptive commentary in the test.
Files Needing Attention: apps/web/tests/unit/rate-limit-ids.test.ts
Important Files Changed
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "fix: preserve teleprompter scroll positi..." | Re-trigger Greptile
Context used (4)