-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: preserve teleprompter scroll position when resuming playback (#2081) #2088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Samarth1306w
wants to merge
4
commits into
CapSoftware:main
Choose a base branch
from
Samarth1306w:fix/teleprompter-resume-position-2081
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
07a82ac
fix(security): wire RATE_LIMIT_IDS to guest-checkout and analytics/tr…
SamarthNimangre 7e94c28
test(security): exempt reserved unwired rate limit IDs in reference c…
59b69c5
test: exclude test file self-references from rate limit contract scanner
Samarth1306w e186c9f
fix: preserve teleprompter scroll position when resuming playback (#2…
Samarth1306w File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import { readFileSync, readdirSync, statSync } from "node:fs"; | ||
| import { join } from "node:path"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { RATE_LIMIT_IDS } from "../../lib/rate-limit"; | ||
|
|
||
| // Rate limit IDs declared in advance for firewall rules or separate app packages | ||
| // that are intentionally not yet wired in apps/web endpoints. | ||
| const UNWIRED_RATE_LIMIT_IDS = new Set([ | ||
| "AUTH_OTP_VERIFY", | ||
| "AUTH_OTP_SEND", | ||
| "LOOM_DOWNLOAD", | ||
| "MESSENGER_MESSAGE", | ||
| "DESKTOP_LOGS", | ||
| ]); | ||
|
|
||
| function getAllTsFiles(dir: string): string[] { | ||
| let results: string[] = []; | ||
| const list = readdirSync(dir); | ||
| for (const file of list) { | ||
| const filePath = join(dir, file); | ||
| const stat = statSync(filePath); | ||
| if (stat && stat.isDirectory()) { | ||
| if (file !== "node_modules" && file !== ".next" && file !== "dist") { | ||
| results = results.concat(getAllTsFiles(filePath)); | ||
| } | ||
| } else if (file.endsWith(".ts") || file.endsWith(".tsx")) { | ||
| if (!filePath.endsWith("lib/rate-limit.ts") && !filePath.endsWith("rate-limit-ids.test.ts")) { | ||
| results.push(filePath); | ||
| } | ||
| } | ||
| } | ||
| return results; | ||
| } | ||
|
|
||
| describe("RATE_LIMIT_IDS reference contract", () => { | ||
| it("ensures every active declared RATE_LIMIT_ID is referenced outside lib/rate-limit.ts", () => { | ||
| const webAppDir = join(process.cwd()); | ||
| const tsFiles = getAllTsFiles(webAppDir); | ||
|
|
||
| let combinedSource = ""; | ||
| for (const file of tsFiles) { | ||
| combinedSource += readFileSync(file, "utf8") + "\n"; | ||
| } | ||
|
|
||
| const unreferencedKeys: string[] = []; | ||
|
|
||
| for (const [key, value] of Object.entries(RATE_LIMIT_IDS)) { | ||
| if (UNWIRED_RATE_LIMIT_IDS.has(key)) { | ||
| continue; | ||
| } | ||
|
|
||
| const hasKeyRef = combinedSource.includes(`RATE_LIMIT_IDS.${key}`); | ||
| const hasValueRef = combinedSource.includes(`"${value}"`) || combinedSource.includes(`'${value}'`); | ||
|
|
||
| if (!hasKeyRef && !hasValueRef) { | ||
| unreferencedKeys.push(key); | ||
| } | ||
| } | ||
|
|
||
| expect( | ||
| unreferencedKeys, | ||
| `The following RATE_LIMIT_IDS are declared but never referenced: ${unreferencedKeys.join(", ")}`, | ||
| ).toEqual([]); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment restates the purpose already conveyed by
UNWIRED_RATE_LIMIT_IDS, adding maintenance noise contrary to the repository's explicit comment policy.Context Used: AGENTS.md (source)
Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!