Conversation
- replace custom button mixin with bitmap button that works in dark mode - add update icon on button - cleanup still necessary
- replace all instances of cornerbuttonmixin with cornerlabelrenderer - some cleanup
CornerButtonGrid is no longer a subclass of CornerButtonMixin, but instead invokes CornerLabelRenderer, so the resulting grid object doesn't have `fn_clicked`, `tooltip` and `label` as attributes. Create getter/setters so it setting these properties on the grid, sets them on the `CornerLabelRenderer` object that the grid object has as an attribute.
default renderers drew white borders, which is ugly in dark mode implement custom renderers using highlight colours to achieve similar look to the regular `Grid`
wxPython >= 4.2.0 uses wxWidgets >= 3.2.0 which is compiled against a newer version of webkit, which doesn't allow loading local resources (in this case images); instead convert them to base64 data urls and pass those to the html
- only veto events on http navigation, else content will load in screen - fix path resolution to icons and base64 encode them - fix various outdated links in html - resolves #4627
- remove comments - resolves #4632
Member
|
I... dont' know what happened with the rebase? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #4632 and #4627