Feature/pbs 25 05#11080
Merged
Merged
Conversation
Add test for is_curator attribute in contributor detail response
…_permissions_classes
…r reset password functionality
Added component reorder validation
…_filter_update [ENG-7291] Update Contributor filter to filter on permissions
…_update [ENG-7294] Add Curator indicator to V2
…ents_reorder [ENG-7300] Upgrade Node Component Reordering to V2.
…utorDetail fix TestNodeContributorDetail
## Purpose Admin should be able to resync CrossRef and DataCite ## Changes Edited template, added celery tasks ## Ticket https://openscience.atlassian.net/browse/ENG-6248
…lready (#11027) ## Purpose Extend admin functionality to enable putting a registration into embargo ## Ticket https://openscience.atlassian.net/browse/ENG-7236
…ed GUIDs (#11021) ## Purpose A preprint link with an unversioned GUID that is followed by “/” will construct an improper URL and fail to resolve. For example, “https://osf.io/preprints/socarxiv/3rhyz/” resolves to “https://osf.io/preprints/socarxiv/3rhyz/3rhyz_v1” and is not an OSF page. ## Changes A link like “[https://osf.io/preprints/socarxiv/3rhyz/](https://osf.io/preprints/socarxiv/3rhyz/3rhyz_v1)” should resolve to the most recent version of that preprint GUID, the same way that “[https://osf.io/preprints/socarxiv/3rhyz](https://osf.io/preprints/socarxiv/3rhyz/3rhyz_v1)” would. ## Ticket https://openscience.atlassian.net/browse/ENG-7338
## Purpose The current `get_preprint` method filters preprints by `is_published = True` that is incorrect in case `pre-moderation` is enabled as in this case preprints have `is_published = False` but still should be visible by users ## Changes Fixed queryset, added tests ## Ticket https://openscience.atlassian.net/browse/ENG-7460 ##Notes If it's never been approved for pre-moderation, then it should 404 for non-contributors, whether it was withdrawn or not. If you are a contributor, it should show for you in the proper state. If it was approved for pre-moderation then withdrawn, it should show as withdrawn for everyone.
## Purpose Recent activity button should redirect to ember app ## Changes Added button with url that is handled by Flask and redirects user's request to ember ## Ticket https://openscience.atlassian.net/browse/ENG-7706
…registration with Datacite (#11050) <!-- Before submit your Pull Request, make sure you picked the right branch: - For hotfixes, select "master" as the target branch - For new features, select "develop" as the target branch - For release feature fixes, select the relevant release branch (release/X.Y.Z) as the target branch --> ## Purpose Possible updates mentioned in the ticket #11014 (review) ## Ticket https://openscience.atlassian.net/browse/ENG-7296
[ENG-7327] Upgrade external_login_email.mako to V2
## Purpose Article DOI aren't validated properly, this is going to address the problem and fix it. ## Changes - Splitting up the one big preprint detail test file into five file ~< 500 lines, so I can zero in on the correct behavior. - Adds new DOIField to `doi` on preprint serializer. - remove superfluous preprint save statements for preprint serializer - Moved article DOI validation into the Preprint model `full_clean` to prevent future issues. ## Ticket https://openscience.atlassian.net/browse/ENG-7461
## Purpose Show preprints in public states ## Changes It's possible that Review Action was not created for published preprint (see `Preprint.set_published()` function for more details). This change will consider public states for different workflows instead of only filtering by review actions for pre-moderation workflow ## QA Notes The easiest way to recreate this bug I was able to found is to create preprint via website, but not submitting it. Instead, go to the admin panel of the preprint and hit "Make published" button. It'll make preprint published with machine state 'accepted', but won't create review action for it. Such preprint will be visible only for provider moderators if provider review workflow is not None. I think there may be some other ways to recreate it (suspect any PATCH /v2/preprints/<preprint_id> request with published=True) All of that should be fixed with this PR ## Ticket https://openscience.atlassian.net/browse/ENG-7707
…ments_waffle_flag [ENG-7339] Implement the “Turn off Comments” flag
## Purpose Use retry method to simplify try..except ## Changes Use retry method instead of sleep ## Ticket https://openscience.atlassian.net/browse/ENG-7741
## Purpose There's a bug where articale DOI keep disappearing after creation, with fixes that and adds a new bunch of tests. ## Changes - Make `arcticle_doi` update work with PATCHing - add regression test. ## Ticket https://openscience.atlassian.net/browse/ENG-7461
[ENG-7698] Fix permission for contributor, when accepting access request
…deprecation [ENG-7333] Depreciate Meetings waffle flag
…est #2 (#11077) ## Purpose Fix issues with addding contributors who are requested. ## Changes - makes selected permission override requested. ## Ticket https://openscience.atlassian.net/browse/ENG-7698
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Merge the feature branch pbs-25-05 to develop