[Frontend][Inbox] Let stalled history detail close - #2426
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent exact-diff review at The Close action uses the existing same-row toggle, leaves P2 tracked on #1999 and declined in this bounded slice: close A, reopen A, then resolve the older A request can satisfy the existing item-id-only freshness guard and clear the newer loading state. The row opener already permits this same sequence, archived detail is read-only, and it does not break the claimed close-and-stay-closed acceptance. A future request-generation guard can harden same-item reopen ordering. |
|
Fresh current-base review at The loading action uses the existing same-row toggle, restores focus after the disclosure closes, and the controlled late response stays suppressed while closed. The current-base Current-base proof: 127/127 focused tests, scoped ESLint, typecheck/build over 810 modules, and diff check passed. Manual browser, screen-reader, and live archived-history API validation were not run. |
Summary
This advances only the stalled-detail residual on #1999. The broader triaged-edit and filter-draft decisions remain open.
Tests
capture-history-loading-closedid not existnpm test -- src/tests/views/paper/PaperInboxView.spec.ts src/tests/views/paper/inbox/PaperTriageTable.spec.ts src/tests/views/paper/inbox/PaperTriageTable.degraded.spec.ts: 127/127 passed on the current-base headnpx eslint src/views/paper/inbox/PaperTriageTable.vue src/tests/views/paper/PaperInboxView.spec.ts --max-warnings=0: passednpm run build: typecheck and production build passed over 810 modules, with the existing ineffective dynamic-import warning fortoastStore.tsgit diff --check origin/main...HEAD: passedReview and gaps
35a190267d52bc23fb640b7bc1cb392e90cfad5e6837bf107c7aa3544beb9554c0249055b900cec6npm cireported existing engine warnings and one moderate audit finding; this branch's product commit changes no dependency fileRefs #1999