Decouple required E2E from Windows frontend unit - #2427
Conversation
…s' into issue-1975/paper-dialog-residuals
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review disposition before hosted qualification:
These do not create a direct incorrect runtime path in the current two-file head, so they are declined for this bounded repair and remain residual under #2378. A fresh exact-head/current-base independent review is in progress. Hosted CI is pending. |
|
Fresh exact-head/current-base independent review completed at Verdict: no CRITICAL/HIGH merge blocker. Verified:
Non-blocking residuals retained under #2378:
No fix commit is warranted in this bounded cycle. Hosted scheduler proof and the required CI conclusion remain the only current gate. |
|
Hosted scheduler evidence from run
This directly proves the scheduling defect is repaired: the known frontend failure no longer suppresses required E2E. Main advanced to |
|
[Codex independent review disposition] Fresh-context current-base review found no CRITICAL or HIGH merge blocker. The base delta from #2426 is isolated from this PR's two-file workflow/test range. LOW, non-blocking: the contract test proves that E2E no longer needs Frontend Unit, but it does not separately assert that the Frontend Unit job still exists. The current workflow does retain that independent job. No fix is added in this bounded scheduler-repair slice. Local exact-head proof: focused dependency contract 2/2, Smart CI suite 88/88, YAML topology parse, and git diff --check all passed. Hosted CI is still in progress. This head is not merge-eligible until its CI and E2E checks complete green. |
…duals Harden board dialogs against focus and live-update clobber
|
[Codex lane release v2] CLAUDE_SYNC_PACKET |
…xpected-error [Security] Sanitize unexpected AgentRuntime failures
…78/e2e-gate-independence-refresh
|
Current-base requalification is pushed at exact head 1c48fce on base 1eb71be. Local proof:
Fresh current-base interaction review found no CRITICAL/HIGH or direct correctness defect. It confirmed Frontend Unit remains independently declared, reusable E2E bootstraps itself, and Smart CI policy remains unchanged. Two LOW observations are declined for this bounded repair: an optional redundant assertion that Frontend Unit remains declared, and pre-existing header wording that says E2E depends on all preceding jobs despite the workflow never doing so. The full seven-check Actionlint integration is not locally verified because native Actionlint and ShellCheck are absent; CI Extended is the authoritative pinned-toolchain proof. Exact-head hosted CI is pending. No merge decision will use the older head's checks. |
|
[Codex lane release v2] CLAUDE_SYNC_PACKET |
|
Live gate update after merged PR #2442 (c37d90b). ADR-0066's 2026-09-03 maintainer amendment now says control-plane (T0/T2) and runner changes merge only after the maintainer's review plus the existing fresh-context review. PR #2427 changes .github/workflows/ci-required.yml, so that human review gate applies. The technical restart contract is unchanged: after the integration wave settles, reconcile once with then-current main, inspect interaction, rerun the focused dependency contract, Smart CI, YAML/governance/diff checks, exact-head hosted CI, and one current-base review. Even if all of that is green, do not merge until the maintainer explicitly reviews this control-plane change. Issue and PR remain Blocked / Priority I. No lease is being reacquired while PR #2443 and the remaining docs/integration work are moving. |
|
Independent fresh-context review disposition for exact head Scope note: the GitHub file list for this PR is inflated against an old base; the effective delta versus the merge base is exactly two items — the No CRITICAL/HIGH defect. Removing the edge deletes a suppression path (a failed or cancelled Windows Frontend Unit leg previously left Non-blocking, recorded on #2378 rather than fixed here (law 2: no fix-commit cascade for MEDIUM/LOW):
|
Summary
frontend-unitfrom the required E2E job'sneedslist so a failed or cancelled Windows launcher leg cannot suppress E2E.Advances #2378.
Evidence
Failing first on the pre-change workflow:
node --test scripts/ci/smart-ci/required-e2e-dependencies.test.mjs: 1 passed, 1 failed because the actual dependency set containedfrontend-unit.Passing at
90f3bc30bf6d728a56c4ca13fcc707ef49104f8eagainstea2ab3e68f79bf8f96ebe49c7dbf2cd1dcf148db:git diff --check origin/main..HEAD: passedHosted run
33737329231on the prior base directly proved E2E scheduled after the known Windows Frontend Unit timeout; the exact evidence is recorded in the PR comments. Hosted CI for the refreshed exact head is pending.Boundaries
This does not fix the Windows 20-second launcher timeout or its path-scope behavior. It prevents that independent job's failure or cancellation from suppressing E2E. Smart CI remains observation-only. Canonical docs are unchanged.