Presigned-URL file transfer (API-key-only upload/download)#3
Merged
Conversation
ryanntannn
force-pushed
the
presigned-urls
branch
from
June 25, 2026 02:39
923f9f0 to
b0f5e51
Compare
Researchers transfer files with only their API key — no S3 credentials ever leave
the cluster. The apiserver mints short-lived presigned URLs (signed against
S3_PUBLIC_ENDPOINT so they're client-reachable); the SDK PUTs/GETs them over plain HTTP.
- POST /v1/uploads → presigned PUT into models/weather + the ref to submit.
- GET /v1/results/{id}/artifacts → presigned GETs scoped to the caller's result.
- SDK PresignedURLBackend (no boto3) auto-selected when no S3 config is present;
direct-S3 backend when creds are given. submit/download unchanged either way.
QA: 30/30 acceptance criteria pass, 0 Critical/High/Medium (docs/QA-presigned.md);
security verified (key-bound URLs, expiry, cross-user 404, no client creds).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019p51SPdbrjmGXJVeZnwTrD
ryanntannn
force-pushed
the
presigned-urls
branch
from
June 25, 2026 02:45
b0f5e51 to
d507de5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Researchers upload models/weather and download results with only their API key — no S3 credentials ever leave the cluster. The apiserver mints short-lived presigned URLs with its own credentials; the SDK
PUTs/GETs them.POST /v1/uploads→ presigned PUT into themodels/weatherbucket + therefto submit.GET /v1/results/{id}/artifacts→ presigned GETs, scoped to the caller's result (cross-user → 404, no leak).PresignedURLBackend(no boto3) is auto-selected when no S3 config is present; the direct-S3 backend is used when creds are given.submit_simulation/download_resultsbehave identically on either.S3_PUBLIC_ENDPOINTso they're reachable from the client; default expiry 300s (≤900s).Why
Closes the static-credential / no-IRSA gap (researchers no longer need S3 keys on their laptops). Pairs with the EKS IRSA work — the apiserver mints URLs using its IRSA role.
Tests / QA
go build/vet/testclean; 16 Go handler tests + 8 SDK tests.docs/QA-presigned.md). Security proven under attack: key-bound URLs (swap → 403), forced-expiry → 403, cross-user → 404, no client-side S3 creds, works without boto3.🤖 Generated with Claude Code