docs: presigned-URL flow as the default (README, TESTING, Compose)#6
Merged
Conversation
Presigned, API-key-only upload/download is the SDK default — show it everywhere instead of direct s3:// refs: - README.md: SDK quickstart uses local file paths + download_results; direct-S3 noted as the advanced option. - TESTING.md: §5 SDK example uses presigned (local paths, get_metrics, download_results). - docker-compose.yml: set S3_PUBLIC_ENDPOINT=http://localhost:9000 so the apiserver mints presigned URLs the host SDK can reach (in-cluster host is minio:9000). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019p51SPdbrjmGXJVeZnwTrD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that presigned-URL transfer (#3) is merged, make it the default flow in the user-facing docs (the SDK already auto-selects it):
download_results; direct-s3://is noted as the advanced opt-in.get_metrics,download_results).S3_PUBLIC_ENDPOINT=http://localhost:9000so the apiserver mints presigned URLs the host SDK can actually reach (the in-cluster MinIO host isminio:9000), making the documented flow work out of the box locally.sdk/python/README.mdwas already presigned-default (merged in #3).🤖 Generated with Claude Code