Fix non-monotonic ProfileEvents increments#109180
Merged
Merged
Conversation
NetworkReceiveBytes and AIOWriteBytes could be incremented with a negative ssize_t (-1 on socket timeout, -errno on AIO failure), wrapping the unsigned counter MemoryOvercommitWaitTimeMicroseconds measured a duration with system_clock, which can step backwards. Guard the amounts and use steady_clock.
Contributor
|
Workflow [PR], commit [5e255c2] Summary: ❌
AI ReviewSummaryThis PR fixes three sources of non-monotonic Tests
Final Verdict
|
Diskein
approved these changes
Jul 2, 2026
azat
enabled auto-merge
July 2, 2026 13:09
Contributor
LLVM Coverage Report
Changed lines: Changed C/C++ lines covered: 20/21 (95.24%) · Uncovered code |
Merged
via the queue into
ClickHouse:master
with commit Jul 3, 2026
d56646c
171 of 174 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkReceiveBytes and AIOWriteBytes could be incremented with a negative ssize_t (-1 on socket timeout, -errno on AIO failure), wrapping the unsigned counter
MemoryOvercommitWaitTimeMicroseconds measured a duration with system_clock, which can step backwards. Guard the amounts and use steady_clock.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix non-monotonic ProfileEvents increments
Version info
26.7.1.481(included in26.7and later)