Fix wrong access type for PREWARM PRIMARY INDEX CACHE ON CLUSTER#109198
Merged
Algunenano merged 2 commits intoJul 3, 2026
Merged
Conversation
getRequiredAccessForDDLOnCluster required SYSTEM PREWARM MARK CACHE for the PREWARM_PRIMARY_INDEX_CACHE case (copy-paste from the neighbouring PREWARM_MARK_CACHE case), while local execution correctly checks SYSTEM PREWARM PRIMARY INDEX CACHE. As a result, a user granted only SYSTEM PREWARM PRIMARY INDEX CACHE was denied the ON CLUSTER variant, and a user with only SYSTEM PREWARM MARK CACHE could run it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [3ea4c6b] Summary: ✅
AI ReviewSummaryThis PR fixes the Final VerdictStatus: ✅ Approve |
clickhouse-gh
Bot
added
the
pr-bugfix
The successful ON CLUSTER query emits a distributed DDL result row whose presence depends on distributed_ddl_output_mode. Force distributed_ddl_output_mode=none so the test has no output regardless of the default profile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
LLVM Coverage Report
Changed lines: Changed C/C++ lines covered: 4/4 (100.00%) · Uncovered code |
asya-ch
approved these changes
Jul 2, 2026
robot-clickhouse-ci-2
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #105133
getRequiredAccessForDDLOnClusterrequiredSYSTEM PREWARM MARK CACHEfor thePREWARM_PRIMARY_INDEX_CACHEcase (copy-paste from the neighbouringPREWARM_MARK_CACHEcase), while local execution correctly checksSYSTEM PREWARM PRIMARY INDEX CACHE. As a result a user granted onlySYSTEM PREWARM PRIMARY INDEX CACHEwas deniedSYSTEM PREWARM PRIMARY INDEX CACHE ... ON CLUSTER, and a user with onlySYSTEM PREWARM MARK CACHEcould run it.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix the access check for
SYSTEM PREWARM PRIMARY INDEX CACHE ... ON CLUSTER, which incorrectly required theSYSTEM PREWARM MARK CACHEprivilege instead ofSYSTEM PREWARM PRIMARY INDEX CACHE.Version info
26.7.1.472(included in26.7and later)