Skip to content

Make 03532_window_function_and_null_source_max_threads not flaky#109330

Merged
alexey-milovidov merged 1 commit into
masterfrom
yarik/fix-flaky-03532
Jul 6, 2026
Merged

Make 03532_window_function_and_null_source_max_threads not flaky#109330
alexey-milovidov merged 1 commit into
masterfrom
yarik/fix-flaky-03532

Conversation

@yariks5s

@yariks5s yariks5s commented Jul 3, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixes flaky 03532_window_function_and_null_source_max_threads. Was failing because of randomized settings. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=109294&sha=8ff33165d8f5565caf0757b07e8955a91728045c&name_0=PR

Version info

  • Merged into: 26.7.1.561 (included in 26.7 and later)

@clickhouse-gh

clickhouse-gh Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Workflow [PR], commit [d2ed3bd]

Summary:


AI Review

Summary

This PR hard-pins the planner inputs for 03532_window_function_and_null_source_max_threads so the test stays on the parallel_hash execution path that its reference already assumes, instead of drifting onto a single-threaded join shape under randomized CI settings. I did not find a correctness, coverage, or PR-metadata issue in the current diff.

Final Verdict

✅ No findings.

@clickhouse-gh clickhouse-gh Bot added the pr-ci label Jul 3, 2026
@clickhouse-gh

clickhouse-gh Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 85.93% 85.95% +0.02%
Functions 91.47% 91.48% +0.00%
Branches 78.43% 78.48% +0.04%

Changed lines: No C/C++ source files changed — skipping uncovered code analysis.

Newly covered by added/modified tests: 161 line(s), 31 function(s) across 56 file(s) · Details

Top files
  • src/Functions/FunctionShowCertificate.cpp: 36 line(s), 2 function(s)
  • src/AggregateFunctions/AggregateFunctionTopK.cpp: 9 line(s), 2 function(s)
  • src/Storages/StorageReplicatedMergeTree.cpp: 9 line(s)
  • src/Functions/printf.cpp: 6 line(s)
  • src/Functions/FunctionsCodingIP.cpp: 5 line(s)

Full report

@alexey-milovidov
alexey-milovidov merged commit 49bf436 into master Jul 6, 2026
173 of 174 checks passed
@alexey-milovidov
alexey-milovidov deleted the yarik/fix-flaky-03532 branch July 6, 2026 18:08
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants