Fix flaky 00965_send_logs_level_concurrent_queries - #110807
Open
tiandiwonder wants to merge 1 commit into
Open
Conversation
The test runs a query at `send_logs_level=trace` and asserts a verbose log line was delivered to the client by matching `<Trace>`. That is flaky: a trivial `SELECT * from numbers(...)` is not guaranteed to emit a `<Trace>`-priority line (the `LOG_TRACE` calls on the query path are all conditional), so under concurrency and randomized settings a run occasionally delivers no `<Trace>` line and the check prints `Fail` (observed as a `-OK/+Fail` diff, flaky on both `master` and pull requests). `executeQuery` always logs the incoming query at `<Debug>` (`logQuery`), which is delivered at trace verbosity but filtered out at information verbosity. Match `<Debug>` as well as `<Trace>`, making the positive check deterministic while keeping it symmetric with the information-level negative check just below (which already asserts `<Debug>`/`<Trace>` are absent). The test still verifies the `send_logs_level` threshold: verbose logs are delivered at `trace` and filtered at `information`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [396c385] Summary: ❌
AI ReviewSummaryThis PR changes Final Verdict✅ No new issues found in the current diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
00965_send_logs_level_concurrent_queriesis flaky on bothmasterand pull requests (surfacing as a-OK/+Faildiff). It runs a query atsend_logs_level=traceand asserts a verbose log line reached the client by matching<Trace>.Root cause
A trivial
SELECT * from numbers(...)is not guaranteed to emit a<Trace>-priority line — everyLOG_TRACEon the query path is conditional. Under concurrency and randomized settings a run occasionally delivers no<Trace>line, so the check printsFail.Solution
executeQueryalways logs the incoming query at<Debug>(logQuery), which is delivered at trace verbosity but filtered out at information verbosity. Match<Debug>as well as<Trace>, making the positive check deterministic and symmetric with the information-level negative check just below (which already asserts<Debug>/<Trace>are absent). The test still verifies thesend_logs_levelthreshold: verbose logs are delivered attraceand filtered atinformation.Verified against a running server: the patched test yields 10
OK, and aninformation-level query delivers no<Debug>/<Trace>lines.Changelog category (leave one):
Documentation entry for user-facing changes